Added linting and package resolution Gitea Actions workflows.

lib/system/base.sh

@@ -76,10 +76,10 @@ install_microcode() {
 
     case "$vendor" in
         "intel")
-            chroot_pacman_install intel-ucode
+            chroot_pacman_install "${INTEL_MICROCODE_PACKAGES[@]}"
             ;;
         "amd")
-            chroot_pacman_install amd-ucode
+            chroot_pacman_install "${AMD_MICROCODE_PACKAGES[@]}"
             ;;
         *)
             print_warning "Unknown CPU vendor: ${vendor}. Please install microcode manually after installation, if available."

lib/system/bootloader.sh

@@ -83,8 +83,10 @@ create_boot_entry() {
     local storage_mode="$1"
 
     if [ "$storage_mode" = "raid1" ]; then
+        # shellcheck disable=SC2153
         create_boot_entry_raid1 "$LUKS_UUID" "$LUKS_UUID_2"
     elif [ "$storage_mode" = "raid1-3disk" ]; then
+        # shellcheck disable=SC2153
         create_boot_entry_raid1_3disk "$LUKS_UUID" "$LUKS_UUID_2" "$LUKS_UUID_3"
     else
         create_boot_entry_single "$LUKS_UUID"

lib/system/network.sh

@@ -65,7 +65,7 @@ enable_resolved() {
 prompt_install_wifi() {
     if confirm "Would you like to install iwd for Wi-Fi support?"; then
         print "Installing iwd..."
-        chroot_pacman_install iwd
+        chroot_pacman_install "${WIFI_PACKAGES[@]}"
         chroot_systemd_enable iwd.service
     fi
 }

lib/system/profiles.sh

@@ -44,28 +44,6 @@ list_profiles() {
     done
 }
 
-# Get packages for a profile
-# Arguments:
-#   $1 - profile key
-# Outputs:
-#   Package list to stdout
-get_profile_packages() {
-    local profile_key="$1"
-    local pkg_var="PROFILE_${profile_key}_PACKAGES[@]"
-    echo "${!pkg_var}"
-}
-
-# Get services for a profile
-# Arguments:
-#   $1 - profile key
-# Outputs:
-#   Service list to stdout
-get_profile_services() {
-    local profile_key="$1"
-    local svc_var="PROFILE_${profile_key}_SERVICES[@]"
-    echo "${!svc_var}"
-}
-
 # Check if profile requires KDE
 # Arguments:
 #   $1 - profile key
@@ -95,8 +73,10 @@ validate_profile_selection() {
 install_profile() {
     local profile_key="$1"
     local username="$2"
-    local packages
-    local services
+    local pkg_var="PROFILE_${profile_key}_PACKAGES[@]"
+    local svc_var="PROFILE_${profile_key}_SERVICES[@]"
+    local packages=("${!pkg_var}")
+    local services=("${!svc_var}")
 
     # Install KDE if required
     if profile_requires_kde "$profile_key"; then
@@ -105,10 +85,8 @@ install_profile() {
     fi
 
     # Get and install profile packages
-    packages=$(get_profile_packages "$profile_key")
-    if [ -n "$packages" ]; then
-        # shellcheck disable=SC2086
-        chroot_pacman_install $packages
+    if [ "${#packages[@]}" -gt 0 ]; then
+        chroot_pacman_install "${packages[@]}"
     fi
 
     # Add user to wireshark group if wireshark was installed
@@ -117,8 +95,7 @@ install_profile() {
     fi
 
     # Enable profile services
-    services=$(get_profile_services "$profile_key")
-    for service in $services; do
+    for service in "${services[@]}"; do
         chroot_systemd_enable "$service"
     done
 }

lib/system/user.sh

@@ -25,6 +25,7 @@ prompt_username() {
     while true; do
         prompt "Please enter the username you'd like to use for your account:" USERNAME
 
+        # shellcheck disable=SC2153
         if validate_username "$USERNAME"; then
             return 0
         fi
@@ -85,6 +86,7 @@ set_user_password() {
 setup_user() {
     prompt_username
     prompt_display_name
+    # shellcheck disable=SC2153
     create_user "$USERNAME" "$DISPLAY_NAME"
     set_user_password "$USERNAME"
 }