From 68ecf4acd18a90628fa5cd2c843b752bd0759295 Mon Sep 17 00:00:00 2001 From: Logan Fick Date: Fri, 31 May 2019 18:17:22 -0400 Subject: [PATCH] Added missing bounds check to dice maximum range. --- src/main/java/dev/logal/logalbot/commands/fun/Dice.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/main/java/dev/logal/logalbot/commands/fun/Dice.java b/src/main/java/dev/logal/logalbot/commands/fun/Dice.java index f9a8b83..fdafe9a 100644 --- a/src/main/java/dev/logal/logalbot/commands/fun/Dice.java +++ b/src/main/java/dev/logal/logalbot/commands/fun/Dice.java @@ -40,6 +40,12 @@ public final class Dice implements Command { .setDeletionDelay(30, TimeUnit.SECONDS); } + if (maximumRange < 1) { + return new CommandResponse("x", + "Sorry " + executor.getAsMention() + ", but the maximum range must be at least 1.") + .setDeletionDelay(30, TimeUnit.SECONDS); + } + return new CommandResponse("game_die", executor.getAsMention() + ", the dice rolled **" + (rng.nextInt(maximumRange) + 1) + "**."); }