Get rid of config global state, improve tests

While dicking around with the tests I noticed that you could make
them fail if you ran them twice. Many hours were spent investigating,
and it turns out that Overviewer's config stuff has global state that
gets modified by having parsed configurations actually modify the
default config values. Not good!

We can fix this by having settingsDefinition return a dict of the
defaults, instead of assigning it to module-level names.

We can also get rid of test_all.py, because what it would do with
pytest is run all tests *twice*. Instead, do the module path stuff
in __init__.py. Also, instead of throwing a non-specific Exception
if exmaple isn't checked out, just skip the test thank you very much.

This is the weirdest rabbit hole I've ever gone down and I haven't
slept in about 30 hours. I'm going to push this commit, and if it
breaks anything, I'll be blissfully asleep as the unwashed masses
begin to riot over exception this traceback that.

overviewer_core/config_parser.py

@@ -33,8 +33,9 @@ class MultiWorldParser:
         # This maps setting names to their values as given in
         # settingsDefinition.py
         self._settings = {}
-        for settingname in dir(settingsDefinition):
-            setting = getattr(settingsDefinition, settingname)
+        default_conf = settingsDefinition.get_default_config()
+        for settingname in default_conf:
+            setting = default_conf[settingname]
             if not isinstance(setting, settingsValidators.Setting):
                 continue
 
@@ -79,7 +80,6 @@ class MultiWorldParser:
         # The global environment should be the rendermode module, so the config
         # file has access to those resources.
         from . import rendermodes
-
         try:
             with open(settings_file, "rb") as settings_file_handle:
                 exec(compile(settings_file_handle.read(), settings_file, 'exec'),

overviewer_core/settingsDefinition.py

@@ -61,56 +61,60 @@ import sys
 # objects with their respective validators.
 
 # config file.
-renders = Setting(required=True, default=OrderedDict(),
-        validator=make_dictValidator(validateStr, make_configDictValidator(
-        {
-            "world": Setting(required=True, validator=validateStr, default=None),
-            "dimension": Setting(required=True, validator=validateDimension, default="default"),
-            "title": Setting(required=True, validator=validateStr, default=None),
-            "rendermode": Setting(required=True, validator=validateRenderMode, default='normal'),
-            "northdirection": Setting(required=True, validator=validateNorthDirection, default=0),
-            "forcerender": Setting(required=False, validator=validateBool, default=None),
-            "imgformat": Setting(required=True, validator=validateImgFormat, default="png"),
-            "imgquality": Setting(required=False, validator=validateImgQuality, default=95),
-            "imglossless": Setting(required=False, validator=validateBool,
-                                   default=True),
-            "bgcolor": Setting(required=True, validator=validateBGColor, default="1a1a1a"),
-            "defaultzoom": Setting(required=True, validator=validateDefaultZoom, default=1),
-            "optimizeimg": Setting(required=True, validator=validateOptImg, default=[]),
-            "nomarkers": Setting(required=False, validator=validateBool, default=None),
-            "texturepath": Setting(required=False, validator=validateTexturePath, default=None),
-            "renderchecks": Setting(required=False, validator=validateInt, default=None),
-            "rerenderprob": Setting(required=True, validator=validateRerenderprob, default=0),
-            "crop": Setting(required=False, validator=validateCrop, default=None),
-            "changelist": Setting(required=False, validator=validateStr, default=None),
-            "markers": Setting(required=False, validator=validateMarkers, default=[]),
-            "overlay": Setting(required=False, validator=validateOverlays, default=[]),
-            "showspawn": Setting(required=False, validator=validateBool, default=True),
-            "base": Setting(required=False, validator=validateStr, default=""),
-            "poititle": Setting(required=False, validator=validateStr, default="Markers"),
-            "customwebassets": Setting(required=False, validator=validateWebAssetsPath, default=None),
-            "maxzoom": Setting(required=False, validator=validateInt, default=None),
-            "minzoom": Setting(required=False, validator=validateInt, default=0),
-            "manualpois": Setting(required=False, validator=validateManualPOIs, default=[]),
-            "showlocationmarker": Setting(required=False, validator=validateBool, default=True),
-            "center": Setting(required=False, validator=validateCoords, default=None),
-            # Remove this eventually (once people update their configs)
-            "worldname": Setting(required=False, default=None,
-                validator=error("The option 'worldname' is now called 'world'. Please update your config files")),
-        }
-        )))
+def get_default_config():
+    conf = dict()
+    conf['renders'] = Setting(required=True, default=OrderedDict(),
+            validator=make_dictValidator(validateStr, make_configDictValidator(
+            {
+                "world": Setting(required=True, validator=validateStr, default=None),
+                "dimension": Setting(required=True, validator=validateDimension, default="default"),
+                "title": Setting(required=True, validator=validateStr, default=None),
+                "rendermode": Setting(required=True, validator=validateRenderMode, default='normal'),
+                "northdirection": Setting(required=True, validator=validateNorthDirection, default=0),
+                "forcerender": Setting(required=False, validator=validateBool, default=None),
+                "imgformat": Setting(required=True, validator=validateImgFormat, default="png"),
+                "imgquality": Setting(required=False, validator=validateImgQuality, default=95),
+                "imglossless": Setting(required=False, validator=validateBool,
+                                    default=True),
+                "bgcolor": Setting(required=True, validator=validateBGColor, default="1a1a1a"),
+                "defaultzoom": Setting(required=True, validator=validateDefaultZoom, default=1),
+                "optimizeimg": Setting(required=True, validator=validateOptImg, default=[]),
+                "nomarkers": Setting(required=False, validator=validateBool, default=None),
+                "texturepath": Setting(required=False, validator=validateTexturePath, default=None),
+                "renderchecks": Setting(required=False, validator=validateInt, default=None),
+                "rerenderprob": Setting(required=True, validator=validateRerenderprob, default=0),
+                "crop": Setting(required=False, validator=validateCrop, default=None),
+                "changelist": Setting(required=False, validator=validateStr, default=None),
+                "markers": Setting(required=False, validator=validateMarkers, default=[]),
+                "overlay": Setting(required=False, validator=validateOverlays, default=[]),
+                "showspawn": Setting(required=False, validator=validateBool, default=True),
+                "base": Setting(required=False, validator=validateStr, default=""),
+                "poititle": Setting(required=False, validator=validateStr, default="Markers"),
+                "customwebassets": Setting(required=False, validator=validateWebAssetsPath, default=None),
+                "maxzoom": Setting(required=False, validator=validateInt, default=None),
+                "minzoom": Setting(required=False, validator=validateInt, default=0),
+                "manualpois": Setting(required=False, validator=validateManualPOIs, default=[]),
+                "showlocationmarker": Setting(required=False, validator=validateBool, default=True),
+                "center": Setting(required=False, validator=validateCoords, default=None),
+                # Remove this eventually (once people update their configs)
+                "worldname": Setting(required=False, default=None,
+                    validator=error("The option 'worldname' is now called 'world'. Please update your config files")),
+            }
+            )))
 
-# The worlds dict, mapping world names to world paths
-worlds = Setting(required=True, validator=make_dictValidator(validateStr, validateWorldPath), default=OrderedDict())
+    # The worlds dict, mapping world names to world paths
+    conf['worlds'] = Setting(required=True, validator=make_dictValidator(validateStr, validateWorldPath), default=OrderedDict())
 
-outputdir = Setting(required=True, validator=validateOutputDir, default=None)
+    conf['outputdir'] = Setting(required=True, validator=validateOutputDir, default=None)
 
-processes = Setting(required=True, validator=int, default=-1)
+    conf['processes'] = Setting(required=True, validator=int, default=-1)
 
-# TODO clean up this ugly in sys.argv hack
-if platform.system() == 'Windows' or not sys.stdout.isatty() or "--simple" in sys.argv:
-    obs = LoggingObserver()
-else:
-    obs = ProgressBarObserver(fd=sys.stdout)
+    # TODO clean up this ugly in sys.argv hack
+    if platform.system() == 'Windows' or not sys.stdout.isatty() or "--simple" in sys.argv:
+        obs = LoggingObserver()
+    else:
+        obs = ProgressBarObserver(fd=sys.stdout)
 
-observer = Setting(required=True, validator=validateObserver, default=obs)
+    conf['observer'] = Setting(required=True, validator=validateObserver, default=obs)
+
+    return conf