indentation and comments added.

web_assets/functions.js

@@ -1,14 +1,15 @@
+// var def
+var map; // god of the overviewer... bow before the google api.
 var markerCollection = {}; // holds groups of markers
-
+var markersInit = false; // only have to load the markers once, this just makes sure we only do it once
-var map;
+var regionsInit = false; // same thing for the regions
-
-var markersInit = false;
-var regionsInit = false;
 
 var prevInfoWindow = null;
 
+// add a popup info window to the marker and then the marker to the map.
+// marker is the clickable image on the map with all data.
+// item is just the same item in the markers.js
 function prepareSignMarker(marker, item) {
-
     var c = "<div class=\"infoWindow\"><img src=\"signpost.png\" /><p>" + item.msg.replace(/\n/g,"<br/>") + "</p></div>";
     var infowindow = new google.maps.InfoWindow({content: c
             });
@@ -21,47 +22,49 @@ function prepareSignMarker(marker, item) {
 
 }
 
+// reusable function for making drop down menus.
+// title = string
+// items = array 
 function createDropDown(title, items) {
     var control = document.createElement("DIV");
     control.id = "customControl"; // let's let a style sheet do most of the styling here
 
+    var controlText = document.createElement("DIV");
+    controlText.innerHTML = title;
+
     var controlBorder = document.createElement("DIV");
     controlBorder.id="top";
     control.appendChild(controlBorder);
-
-    var controlText = document.createElement("DIV");
-
     controlBorder.appendChild(controlText);
 
-    controlText.innerHTML = title;
-    
     var dropdownDiv = document.createElement("DIV");
-
-
-    $(controlText).click(function() {
-            $(dropdownDiv).toggle();
-
-            });
-
-
     dropdownDiv.id="dropDown";
     control.appendChild(dropdownDiv);
     dropdownDiv.innerHTML="";
 
+    // add the functionality to toggle visibility of the items
+    $(controlText).click(function() {
+            $(dropdownDiv).toggle();
+        });
+    
+    // add that control box we've made back to the map.
     map.controls[google.maps.ControlPosition.TOP_RIGHT].push(control);
 
     for (idx in items) {
+        // create the visible elements of the item
         var item = items[idx];
-        //console.log(item);
+        //console.log(item); // debug
         var d = document.createElement("div");
         var n = document.createElement("input");
         n.type="checkbox";
 
+        // give it a name
         $(n).data("label",item.label);
         jQuery(n).click(function(e) {
                 item.action(idx, item.label, e.target.checked);
             });
 
+        // if its checked, its gotta do something, do that here.
         if (item.checked) {
             n.checked = true;
             item.action(idx, item.label, item.checked);
@@ -74,32 +77,28 @@ function createDropDown(title, items) {
     }
 }
 
+// need to define the controls including the compass and layer controls. top right!
+// input variables are for chumps... and reusable functions. this is neither.
 function drawMapControls() {
 
-    // viewstate link
+    // viewstate link (little link to where you're looking at the map, normally bottom left)
     var viewStateDiv = document.createElement('DIV');
-
-        //<div id="link" style="border:1px solid black;background-color:white;color:black;position:absolute;top:5px;right:5px"></div>
-
     viewStateDiv.id="link";
-
+    // add it to the map, bottom left.
-
+    map.controls[google.maps.ControlPosition.BOTTOM_LEFT].push(viewStateDiv);
-    map.controls[google.maps.ControlPosition.BOTTOM_RIGHT].push(viewStateDiv);
-
 
     // compass rose, in the top right corner
     var compassDiv = document.createElement('DIV');
-
     compassDiv.style.padding = '5px';
-
     var compassImg = document.createElement('IMG');
     compassImg.src="compass.png";
     compassDiv.appendChild(compassImg);
-
     compassDiv.index = 0;
+    // add it to the map, top right.
     map.controls[google.maps.ControlPosition.TOP_RIGHT].push(compassDiv);
 
 
+    // only need to create the control if there are items in the list. as definned in config.js
     if (signGroups.length > 0) {
         // signpost display control
         
@@ -127,9 +126,7 @@ function drawMapControls() {
                         } else {
                             var idx_to_delete = -1;
                             map.overlayMapTypes.forEach(function(e, j) {
-                                                                if (e == overlay) {
+                                    if (e == overlay) { idx_to_delete = j; }
-                                                                    idx_to_delete = j;
-                                                                }
                                 });
                             if (idx_to_delete >= 0) {
                                 map.overlayMapTypes.removeAt(idx_to_delete);
@@ -141,6 +138,8 @@ function drawMapControls() {
     }
 }
 
+// will be recoded by pi, currently always displays all regions all the time.
+// parse the data as definned in the regions.js
 function initRegions() {
     if (regionsInit) { return; }
 
@@ -180,12 +179,11 @@ function initRegions() {
     }
 }
 
-
+// will initalize all the markers data as found in markers.js
-
+// may need to be reviewed by agrif or someone else... little finicky right now.
 function initMarkers() {
-    if (markersInit) { return; }
+    if (markersInit) { return; } // oh, we've already done this? nevermind, exit the function.
-
+    markersInit = true; // now that we've started, dont have to do it twice.
-    markersInit = true;
     
     // first, give all collections an empty array to work with
     for (i in signGroups) {
@@ -207,7 +205,6 @@ function initMarkers() {
                     title: jQuery.trim(item.msg), 
                     icon: iconURL
                 });
-
             continue;
         }
 
@@ -220,11 +217,11 @@ function initMarkers() {
             if (testfunc(item)) {
                 matched = true;
 
-                if (item.type == 'sign') { iconURL = 'signpost_icon.png';}
+                // can add custom types of images for externally definned item types, like 'command' here.
+                if (item.type == 'sign') { iconURL = 'signpost_icon.png'; }
 
-                //console.log(signGroup.icon);
+                //console.log(signGroup.icon); //debug
-                if (signGroup.icon) { iconURL = signGroup.icon; 
+                if (signGroup.icon) { iconURL = signGroup.icon; }
-                }
 
                 var converted = fromWorldToLatLng(item.x, item.y, item.z);
                 var marker = new google.maps.Marker({position: converted,
@@ -271,7 +268,7 @@ function initMarkers() {
     }
 }
 
-
+// update the link in the viewstate. 
 function makeLink() {
     var a=location.href.substring(0,location.href.lastIndexOf(location.search))
         + "?lat=" + map.getCenter().lat().toFixed(6)
@@ -280,6 +277,7 @@ function makeLink() {
     document.getElementById("link").innerHTML = a;
 }
 
+// load the map up and add all the functions relevant stuff to the map.
 function initialize() {
 
     var query = location.search.substring(1);
@@ -364,33 +362,33 @@ function initialize() {
 }
 
 
-  // our custom projection maps Latitude to Y, and Longitude to X as normal,
+// our custom projection maps Latitude to Y, and Longitude to X as normal,
-  // but it maps the range [0.0, 1.0] to [0, tileSize] in both directions
+// but it maps the range [0.0, 1.0] to [0, tileSize] in both directions
-  // so it is easier to position markers, etc. based on their position
+// so it is easier to position markers, etc. based on their position
-  // (find their position in the lowest-zoom image, and divide by tileSize)
+// (find their position in the lowest-zoom image, and divide by tileSize)
-  function MCMapProjection() {
+function MCMapProjection() {
     this.inverseTileSize = 1.0 / config.tileSize;
-  }
+}
   
-  MCMapProjection.prototype.fromLatLngToPoint = function(latLng) {
+MCMapProjection.prototype.fromLatLngToPoint = function(latLng) {
     var x = latLng.lng() * config.tileSize;
     var y = latLng.lat() * config.tileSize;
     return new google.maps.Point(x, y);
-  };
+};
 
-  MCMapProjection.prototype.fromPointToLatLng = function(point) {
+MCMapProjection.prototype.fromPointToLatLng = function(point) {
     var lng = point.x * this.inverseTileSize;
     var lat = point.y * this.inverseTileSize;
     return new google.maps.LatLng(lat, lng);
-  };
+};
   
-  // helper to get map LatLng from world coordinates
+// helper to get map LatLng from world coordinates
-  // takes arguments in X, Y, Z order
+// takes arguments in X, Y, Z order
-  // (arguments are *out of order*, because within the function we use
+// (arguments are *out of order*, because within the function we use
-  // the axes like the rest of Minecraft Overviewer -- with the Z and Y
+// the axes like the rest of Minecraft Overviewer -- with the Z and Y
-  // flipped from normal minecraft usage.)
+// flipped from normal minecraft usage.)
-  function fromWorldToLatLng(x, z, y)
+function fromWorldToLatLng(x, z, y)
-  {
+{
     // the width and height of all the highest-zoom tiles combined, inverted
     var perPixel = 1.0 / (config.tileSize * Math.pow(2, config.maxZoom));
 
@@ -421,7 +419,7 @@ function initialize() {
     lng += 12 * perPixel;
 
     return new google.maps.LatLng(lat, lng);
-  }
+}
   
 function getTileUrlGenerator(path, path_base) {
     return function(tile, zoom) {
@@ -478,14 +476,14 @@ for (idx in mapTypeData) {
   }
 }
   
-  function CoordMapType() {
+function CoordMapType() {
-  }
+}
   
-  function CoordMapType(tileSize) {
+function CoordMapType(tileSize) {
     this.tileSize = tileSize;
-  }
+}
   
-  CoordMapType.prototype.getTile = function(coord, zoom, ownerDocument) {
+CoordMapType.prototype.getTile = function(coord, zoom, ownerDocument) {
     var div = ownerDocument.createElement('DIV');
     div.innerHTML = "(" + coord.x + ", " + coord.y + ", " + zoom + ")";
     div.innerHTML += "<br />";
@@ -497,4 +495,4 @@ for (idx in mapTypeData) {
     div.style.borderWidth = '1px';
     div.style.borderColor = '#AAAAAA';
     return div;
-  };
+};