From 454c1537a6099d5dc2168c11b1cf0a5db2507891 Mon Sep 17 00:00:00 2001 From: Aaron Griffith Date: Wed, 8 Jun 2011 14:57:21 -0400 Subject: [PATCH] sign drop-down now only shows rules that actually match something --- web_assets/overviewer.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/web_assets/overviewer.js b/web_assets/overviewer.js index 467affb..615e78a 100644 --- a/web_assets/overviewer.js +++ b/web_assets/overviewer.js @@ -598,6 +598,11 @@ var overviewer = { var items = []; for (i in overviewerConfig.objectGroups.signs) { var signGroup = overviewerConfig.objectGroups.signs[i]; + // don't create an option for this group if empty + if (overviewer.collections.markers[signGroup.label].length == 0) { + continue; + } + var iconURL = signGroup.icon; if(!iconURL) { iconURL = overviewerConfig.CONST.image.defaultMarker; @@ -616,7 +621,11 @@ var overviewer = { } }); } - overviewer.util.createDropDown('Signposts', items); + + // only create drop down if there's used options + if (items.length > 0) { + overviewer.util.createDropDown('Signposts', items); + } } // if there are any regions data, lets show the option to hide/show them.