LogalDeveloper/Minecraft-Overviewer
Archived
0
Fork 0
Code Activity

Fix marker icon position properly. Closes #1481.

Browse Source 
CSS margin is always relative to the containing element. For some
reason, using the browser inspector, this does not get propagated
properly. Adding a containing element with the size of the child element
allows us to use margin to offset the icon.
This commit is contained in:
Willem Mulder
2019-01-23 21:13:59 +01:00
parent bde265a8ac
commit ad5c419546
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
overviewer_core/data/js_src/util.js
View File

@@ -334,8 +334,7 @@ overviewer.util = {
for (var mkidx = 0; mkidx < markers[obj.path].length; mkidx++) { for (var mkidx = 0; mkidx < markers[obj.path].length; mkidx++) {
var marker_group = new L.layerGroup(); var marker_group = new L.layerGroup();
var marker_entry = markers[obj.path][mkidx]; var marker_entry = markers[obj.path][mkidx];
var icon = L.icon({iconUrl: marker_entry.icon, var icon = L.divIcon({html: `<img class="ov-marker" src="${marker_entry.icon}">`});
className: "ov-marker"});
console.log("marker group:", marker_entry.displayName, marker_entry.groupName); console.log("marker group:", marker_entry.displayName, marker_entry.groupName);
for (var dbidx = 0; dbidx < markersDB[marker_entry.groupName].raw.length; dbidx++) { for (var dbidx = 0; dbidx < markersDB[marker_entry.groupName].raw.length; dbidx++) {
@@ -343,8 +342,7 @@ overviewer.util = {
var latlng = overviewer.util.fromWorldToLatLng(db.x, db.y, db.z, obj); var latlng = overviewer.util.fromWorldToLatLng(db.x, db.y, db.z, obj);
var m_icon; var m_icon;
if (db.icon != undefined) { if (db.icon != undefined) {
m_icon = L.icon({iconUrl: db.icon, m_icon = L.divIcon({html: `<img class="ov-marker" src="${db.icon}">`});
className: "ov-marker"});
} else { } else {
m_icon = icon; m_icon = icon;
} }