From c29c983a7960c382a8e6b60022083fa027cc7ce2 Mon Sep 17 00:00:00 2001 From: Andrew Chin Date: Fri, 27 Jan 2012 19:37:16 -0500 Subject: [PATCH] Print a more user friendly error message on validation failure --- overviewer.py | 7 ++++++- overviewer_core/configParser.py | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/overviewer.py b/overviewer.py index e30d93f..0bef260 100755 --- a/overviewer.py +++ b/overviewer.py @@ -264,7 +264,12 @@ dir but you forgot to put quotes around the directory, since it contains spaces. # look at our settings.py file mw_parser = configParser.MultiWorldParser("settings.py") mw_parser.parse() - mw_parser.validate() + try: + mw_parser.validate() + except Exception: + logging.error("Please investigate these errors in settings.py then try running Overviewer again") + return 1 + # create our asset manager... ASSMAN assetMrg = assetmanager.AssetManager(destdir) diff --git a/overviewer_core/configParser.py b/overviewer_core/configParser.py index 97667e7..a048830 100644 --- a/overviewer_core/configParser.py +++ b/overviewer_core/configParser.py @@ -289,7 +289,8 @@ class MultiWorldParser(object): origs[key + "_orig"] = world[key] world[key] = val except Exception as e: - print "Error validating %s: %r" % (key, e) + logging.error("Error validating '%s' option in render definition for '%s':", key, worldname) + logging.error(e) raise e world['name'] = worldname world.update(origs)