From 7d8bd00a848a8c00c33f4503f21b00eb4c2377a8 Mon Sep 17 00:00:00 2001 From: Andrew Brown Date: Sun, 26 Feb 2012 21:17:55 -0500 Subject: [PATCH 1/2] Made the assetmanager initalize() and finalize() organization slightly clearer --- overviewer_core/assetmanager.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/overviewer_core/assetmanager.py b/overviewer_core/assetmanager.py index 26734b4..37159a2 100644 --- a/overviewer_core/assetmanager.py +++ b/overviewer_core/assetmanager.py @@ -78,13 +78,16 @@ directory. config. """ - return self.finalize(tilesets, True) + self._output_assets(tilesets, True) - def finalize(self, tilesets, initial=False): + def finalize(self, tilesets): """Called to output the generated javascript and all static files to the output directory """ + self._output_assets(tilesets, False) + + def _output_assets(self, tilesets, initial): if not initial: get_data = lambda tileset: tileset.get_persistent_data() else: From 814ef86221336c3608317216b675b16673491a12 Mon Sep 17 00:00:00 2001 From: Andrew Brown Date: Sun, 26 Feb 2012 21:46:25 -0500 Subject: [PATCH 2/2] added disclaimer to the crop option --- docs/config.rst | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docs/config.rst b/docs/config.rst index 5473cd3..7d8b1c8 100644 --- a/docs/config.rst +++ b/docs/config.rst @@ -349,6 +349,20 @@ values. The valid configuration keys are listed below. 'crop': (-500, -500, 500, 500), } + .. warning:: + + If you decide to change the bounds on a render, you may find it produces + unexpected results. + + For an expansion to the bounds, because chunks in the new bounds have + the same mtime as the old, tiles will not automatically be updated. You + may need to use :option:`--forcerender` to force those tiles to update. + + For reductions to the bounds, because there is currently no mechanism to + detect tiles that shouldn't exist but do, old tiles may remain and will + not get deleted. The only fix for this currently is to delete that + render directory and render it again with :option:`--forcerender`. + .. _customrendermodes: Custom Rendermodes and Rendermode Primitives