0
Commit Graph

11 Commits

Author SHA1 Message Date
Nicolas F
0d3d630104 Get rid of config global state, improve tests
While dicking around with the tests I noticed that you could make
them fail if you ran them twice. Many hours were spent investigating,
and it turns out that Overviewer's config stuff has global state that
gets modified by having parsed configurations actually modify the
default config values. Not good!

We can fix this by having settingsDefinition return a dict of the
defaults, instead of assigning it to module-level names.

We can also get rid of test_all.py, because what it would do with
pytest is run all tests *twice*. Instead, do the module path stuff
in __init__.py. Also, instead of throwing a non-specific Exception
if exmaple isn't checked out, just skip the test thank you very much.

This is the weirdest rabbit hole I've ever gone down and I haven't
slept in about 30 hours. I'm going to push this commit, and if it
breaks anything, I'll be blissfully asleep as the unwashed masses
begin to riot over exception this traceback that.
2019-07-24 17:02:39 +02:00
Nicolas F
c13d3aae3c rename configParser to config_parser
CamelCase does not bode well in Python land, so it's best we rename
these ill-named files before the Guidoists get us and throw us into
a damp dungeon.
2019-07-24 09:18:02 +02:00
Nicolas F
e348a548b6 Initial Python 3 port
Many things work, some don't. Notably, genPOI doesn't work, and
there's some signedness comparison stuff going on in the C extension.

This also completely drops support for Python 2, as maintaining a C
extension for both Python 2 and 3 is a pain and not worth it for the
9 months that Python 2 is still going to be supported upstream.

The documentation needs to be adjusted as well.

All of the few tests we have pass, and rendering a map works, both
with a configuration file and without. We can also use optimizeimages.

Concerns #1528.
2019-03-17 17:57:07 +01:00
Johan Kiviniemi
c32abc00e0 test_settings/test_manual: Match renders order with file 2013-12-27 03:46:03 +02:00
Johan Kiviniemi
b1bd77d962 test_settings: ValueError → MissingConfigException 2013-12-27 03:24:08 +02:00
Andrew Brown
aaf8e1d7cb Changed "worldname" to "world" in configfile
Also brought tests up to date. All tests pass now.
2012-02-14 20:39:05 -05:00
Andrew Brown
6d95d80a73 overhaul to configParser. Parsing config works now. 2012-02-04 21:23:44 -05:00
Andrew Chin
c14cd1a66f Fixed/added some config parsing tests 2012-01-02 01:13:29 -05:00
Aaron Griffith
a1dc392526 c_overviewer is now auto-initialized, and some other minor fixes 2012-01-02 00:40:56 -05:00
Andrew Chin
287b16fd13 Fixing some settings stuff 2012-01-02 00:03:10 -05:00
Andrew Chin
2d99aef78f Start of some unit tests for setting.py parsing 2011-12-28 16:04:24 -05:00