LogalDeveloper/Owlbot
0
Fork 0
Code Issues 13 Actions Packages Releases 3 Wiki Activity

Removed unnecessary character validation from placeholder name parsing.
Format / ruff (push) Successful in 11s
Details
Lint / ruff (push) Successful in 11s
Details
Unit Tests / pytest (push) Successful in 18s
Details
Type Check / mypy (push) Successful in 18s
Details

Browse Source
This commit is contained in:
LogalDeveloper
2026-02-16 19:46:08 -05:00
parent 24aa484d7f
commit b8e7663bf4
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
owlbot/builtin_modules/custom_commands/placeholders.py
+2 -4
View File
@@ -138,7 +138,7 @@ def _parse_placeholder(
) -> tuple[PlaceholderNode, int] | None: ) -> tuple[PlaceholderNode, int] | None:
"""Parse a single placeholder after the opening ``$(`` has been consumed. """Parse a single placeholder after the opening ``$(`` has been consumed.
Reads the placeholder name (word characters up to a space, ``)``, ``$``, Reads the placeholder name (any characters up to a space, ``)``, ``$``,
or end-of-string), then parses children if the name is followed by a space. or end-of-string), then parses children if the name is followed by a space.
:param template: The full template string. :param template: The full template string.
@@ -150,11 +150,9 @@ def _parse_placeholder(
""" """
length = len(template) length = len(template)
# Read the placeholder name: word characters (\w) up to a delimiter. # Read the placeholder name: any characters up to a delimiter.
name_start = pos name_start = pos
while pos < length and template[pos] not in (" ", ")", "$"): while pos < length and template[pos] not in (" ", ")", "$"):
if not (template[pos].isalnum() or template[pos] == "_"):
break
pos += 1 pos += 1
name = template[name_start:pos] name = template[name_start:pos]