Added pydocstyle (D) rules to Ruff and fixed all violations.
CI / Formatting (push) Successful in 12s
CI / Linting (push) Successful in 13s
CI / Tests (Python 3.12) (push) Successful in 26s
CI / Tests (Python 3.13) (push) Successful in 25s
CI / Tests (Python 3.14) (push) Successful in 25s
CI / Type Checking (push) Successful in 26s

This commit is contained in:
2026-02-19 11:47:47 -05:00
parent 33dd49e20a
commit ca4adbcebf
30 changed files with 309 additions and 591 deletions
@@ -56,8 +56,7 @@ __all__ = [
@on_setup
async def setup(ctx: ModuleContext) -> None:
"""
Initialize the custom_commands module.
"""Initialize the custom_commands module.
Creates the database schema and loads existing commands from the database.
@@ -30,8 +30,7 @@ from .placeholders import DEFAULT_MAX_DEPTH, process_placeholders
async def get_aliases_for_command(
storage: ModuleStorage, command_name: str
) -> list[str]:
"""
Fetch all aliases for a command from the database.
"""Fetch all aliases for a command from the database.
:param storage: The module storage instance.
:param command_name: The canonical command name.
@@ -47,8 +46,7 @@ async def get_aliases_for_command(
async def resolve_command_name(
storage: ModuleStorage, name: str
) -> aiosqlite.Row | None:
"""
Resolve a command name or alias to the full command row.
"""Resolve a command name or alias to the full command row.
Checks the commands table first, then falls back to the aliases table.
Returns the command's name, requires_moderator, and cooldown columns.
@@ -70,8 +68,7 @@ async def resolve_command_name(
async def custom_command_handler(ctx: CommandContext) -> None:
"""
Shared handler for all custom commands.
"""Shared handler for all custom commands.
Looks up the command in the database, increments use count,
processes placeholders, and sends the response.
@@ -112,8 +109,7 @@ def reregister_command(
requires_moderator: bool,
cooldown: int,
) -> None:
"""
Unregister and re-register a custom command with updated settings.
"""Unregister and re-register a custom command with updated settings.
Both registry operations are synchronous, so no other coroutine can observe
the intermediate unregistered state.
@@ -67,8 +67,7 @@ async def _resolve_or_error(ctx: CommandContext, raw_name: str) -> aiosqlite.Row
@on_command("addcommand", aliases=["addcmd"], requires_moderator=True)
async def addcommand(ctx: CommandContext) -> None:
"""
Create a new custom command.
"""Create a new custom command.
Usage: !addcommand !name response text
@@ -134,8 +133,7 @@ async def addcommand(ctx: CommandContext) -> None:
@on_command("editcommand", aliases=["editcmd"], requires_moderator=True)
async def editcommand(ctx: CommandContext) -> None:
"""
Edit an existing custom command's response.
"""Edit an existing custom command's response.
Usage: !editcommand !name new response
@@ -175,8 +173,7 @@ async def editcommand(ctx: CommandContext) -> None:
@on_command("deletecommand", aliases=["delcmd"], requires_moderator=True)
async def deletecommand(ctx: CommandContext) -> None:
"""
Delete a custom command.
"""Delete a custom command.
Usage: !deletecommand !name
@@ -215,8 +212,7 @@ async def deletecommand(ctx: CommandContext) -> None:
@on_command("commandmodonly", aliases=["cmdmodonly"], requires_moderator=True)
async def commandmodonly(ctx: CommandContext) -> None:
"""
Toggle moderator-only access for a custom command.
"""Toggle moderator-only access for a custom command.
Usage: !commandmodonly !name <on|off>
@@ -255,8 +251,7 @@ async def commandmodonly(ctx: CommandContext) -> None:
@on_command("resetcommand", aliases=["resetcmd"], requires_moderator=True)
async def resetcommand(ctx: CommandContext) -> None:
"""
Reset a custom command's use counter to 0.
"""Reset a custom command's use counter to 0.
Usage: !resetcommand !name
@@ -288,8 +283,7 @@ async def resetcommand(ctx: CommandContext) -> None:
@on_command("editcounter", aliases=["editcount"], requires_moderator=True)
async def editcounter(ctx: CommandContext) -> None:
"""
Set, increment, or decrement a named counter.
"""Set, increment, or decrement a named counter.
Usage: !editcounter <name> <value>
@@ -351,8 +345,7 @@ async def editcounter(ctx: CommandContext) -> None:
@on_command("commandcooldown", aliases=["cmdcooldown"], requires_moderator=True)
async def commandcooldown(ctx: CommandContext) -> None:
"""
Set or disable a custom command's cooldown.
"""Set or disable a custom command's cooldown.
Usage: !commandcooldown !name <seconds>
@@ -404,8 +397,7 @@ async def commandcooldown(ctx: CommandContext) -> None:
@on_command("addalias", requires_moderator=True)
async def addalias(ctx: CommandContext) -> None:
"""
Add an alias to an existing custom command.
"""Add an alias to an existing custom command.
Usage: !addalias !command !alias
@@ -485,8 +477,7 @@ async def addalias(ctx: CommandContext) -> None:
@on_command("removealias", requires_moderator=True)
async def removealias(ctx: CommandContext) -> None:
"""
Remove an alias from a custom command.
"""Remove an alias from a custom command.
Usage: !removealias !alias
@@ -535,8 +526,7 @@ async def removealias(ctx: CommandContext) -> None:
@on_command("listcommands", aliases=["listcmds"], cooldown=15)
async def listcommands(ctx: CommandContext) -> None:
"""
List all custom commands.
"""List all custom commands.
Sends a URL to the command list web page.
Has a 15-second cooldown to prevent spam.
@@ -105,10 +105,10 @@ class PlaceholderContext:
def _find_matching_close(template: str, pos: int) -> int:
"""Find the position of the ``)`` that closes an escaped ``\\$(...)`` group.
r"""Find the position of the ``)`` that closes an escaped ``\$(...)`` group.
Tracks nested ``$(`` / ``)`` pairs so that escaped groups containing inner
placeholders (e.g. ``\\$(rand $(1) $(2))``) are consumed in their entirety.
placeholders (e.g. ``\$(rand $(1) $(2))``) are consumed in their entirety.
:param template: The full template string.
:param pos: The position immediately after the opening ``$(`` of the
@@ -30,8 +30,7 @@ _jinja_env = jinja2.Environment(
@on_route("/list", methods=["GET"])
async def command_list_page(ctx: RouteContext) -> web.Response:
"""
Serve an HTML page listing all custom commands in a table.
"""Serve an HTML page listing all custom commands in a table.
Columns: Command, Aliases, Response, Cooldown, Permissions.
Accessible at /owlbot/custom_commands/list.