From 0fccaa61fee5558eaa2a0a2c4847b0bd5156afa3 Mon Sep 17 00:00:00 2001 From: Gabe Kangas Date: Sat, 26 Oct 2024 12:22:19 -0700 Subject: [PATCH] fix(video): fix nil reference exception in playback metrics. Closes #3984 --- webserver/handlers/playbackMetrics.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/webserver/handlers/playbackMetrics.go b/webserver/handlers/playbackMetrics.go index 1bb7954bd..3b4003465 100644 --- a/webserver/handlers/playbackMetrics.go +++ b/webserver/handlers/playbackMetrics.go @@ -30,15 +30,15 @@ func ReportPlaybackMetrics(w http.ResponseWriter, r *http.Request) { clientID := utils.GenerateClientIDFromRequest(r) metrics.RegisterPlaybackErrorCount(clientID, *request.Errors) - if *request.Bandwidth != 0.0 { + if request.Bandwidth != nil && *request.Bandwidth != 0.0 { metrics.RegisterPlayerBandwidth(clientID, *request.Bandwidth) } - if *request.Latency != 0.0 { + if request.Latency != nil && *request.Latency != 0.0 { metrics.RegisterPlayerLatency(clientID, *request.Latency) } - if *request.DownloadDuration != 0.0 { + if request.DownloadDuration != nil && *request.DownloadDuration != 0.0 { metrics.RegisterPlayerSegmentDownloadDuration(clientID, *request.DownloadDuration) }