LogalDeveloper/owncast
LogalDeveloper/owncast
0
Fork 0
Code

Improve performance of retrieving chat history by avoiding double-sort and outer join (#1261)

Browse Source
This commit is contained in:
Christian Muehlhaeuser 2021-07-25 18:54:24 +02:00 committed by GitHub
parent 261fe56bad
commit 35a0c6fa14
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/chat/persistence.go
View File

@ -156,8 +156,15 @@ func GetChatModerationHistory() []events.UserMessageEvent {
func GetChatHistory() []events.UserMessageEvent { func GetChatHistory() []events.UserMessageEvent {
// Get all visible messages // Get all visible messages
var query = fmt.Sprintf("SELECT id, user_id, body, eventType, hidden_at, timestamp, display_name, display_color, created_at, disabled_at, previous_names, namechanged_at FROM (SELECT * FROM messages LEFT OUTER JOIN users ON messages.user_id = users.id WHERE hidden_at IS NULL AND disabled_at IS NULL ORDER BY timestamp DESC LIMIT %d) ORDER BY timestamp asc", maxBacklogNumber) var query = fmt.Sprintf("SELECT messages.id, user_id, body, eventType, hidden_at, timestamp, display_name, display_color, created_at, disabled_at, previous_names, namechanged_at FROM messages, users WHERE messages.user_id = users.id AND hidden_at IS NULL AND disabled_at IS NULL ORDER BY timestamp DESC LIMIT %d", maxBacklogNumber)
return getChat(query) m := getChat(query)
// Invert order of messages
for i, j := 0, len(m)-1; i < j; i, j = i+1, j-1 {
m[i], m[j] = m[j], m[i]
}
return m
} }
// SetMessageVisibilityForUserId will bulk change the visibility of messages for a user // SetMessageVisibilityForUserId will bulk change the visibility of messages for a user