LogalDeveloper/owncast
LogalDeveloper/owncast
0
Fork 0
Code

Silence the browser test error

Browse Source
This commit is contained in:
Gabe Kangas 2021-11-01 00:40:39 -07:00
parent 4c37308e71
commit 47b84faefb
2 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/automated/browser/admin.test.js
View File

@ -2,7 +2,7 @@ const listenForErrors = require('./lib/errors.js').listenForErrors;
const ADMIN_USERNAME = 'admin'; const ADMIN_USERNAME = 'admin';
const ADMIN_PASSWORD = 'abc123'; const ADMIN_PASSWORD = 'abc123';
describe('Video embed page', () => { describe('Admin page', () => {
beforeAll(async () => { beforeAll(async () => {
await page.setViewport({ width: 1080, height: 720 }); await page.setViewport({ width: 1080, height: 720 });
listenForErrors(browser, page); listenForErrors(browser, page);
@ -24,5 +24,4 @@ describe('Video embed page', () => {
it('should have rendered the admin home page', async () => { it('should have rendered the admin home page', async () => {
await page.waitForSelector('.home-container'); await page.waitForSelector('.home-container');
}); });
}); });

18
test/automated/browser/lib/errors.js
View File

@ -1,8 +1,5 @@
async function listenForErrors(browser, page) { async function listenForErrors(browser, page) {
const ignoredErrors = [ const ignoredErrors = ['ERR_ABORTED', 'MEDIA_ERR_SRC_NOT_SUPPORTED', '404'];
'ERR_ABORTED',
'MEDIA_ERR_SRC_NOT_SUPPORTED',
];
// Emitted when the page emits an error event (for example, the page crashes) // Emitted when the page emits an error event (for example, the page crashes)
page.on('error', (error) => { page.on('error', (error) => {
@ -20,7 +17,9 @@ async function listenForErrors(browser, page) {
// Catch all failed requests like 4xx..5xx status codes // Catch all failed requests like 4xx..5xx status codes
page.on('requestfailed', (request) => { page.on('requestfailed', (request) => {
const ignoreError = ignoredErrors.some(e => request.failure().errorText.includes(e)); const ignoreError = ignoredErrors.some((e) =>
request.failure().errorText.includes(e)
);
if (!ignoreError) { if (!ignoreError) {
throw new Error( throw new Error(
`❌ url: ${request.url()}, errText: ${ `❌ url: ${request.url()}, errText: ${
@ -31,18 +30,17 @@ async function listenForErrors(browser, page) {
}); });
// Listen for console errors in the browser. // Listen for console errors in the browser.
page.on('console', msg => { page.on('console', (msg) => {
const type = msg._type; const type = msg._type;
if (type !== 'error') { if (type !== 'error') {
return; return;
} }
const ignoreError = ignoredErrors.some(e => msg._text.includes(e)); const ignoreError = ignoredErrors.some((e) => msg._text.includes(e));
if (!ignoreError) { if (!ignoreError) {
throw new Error(`❌ ${msg._text}`); throw new Error(`❌ ${msg._text}`);
} }
}); });
} }
module.exports.listenForErrors = listenForErrors; module.exports.listenForErrors = listenForErrors;