From 48a1b618680e9dddbe838c0cd044deceda676fdd Mon Sep 17 00:00:00 2001 From: Gabe Kangas Date: Sun, 7 Feb 2021 19:41:52 -0800 Subject: [PATCH 1/2] Fix the NaN for the width/height settings --- web/components/config/video-variant-form.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/web/components/config/video-variant-form.tsx b/web/components/config/video-variant-form.tsx index 0d850f618..5e0035b65 100644 --- a/web/components/config/video-variant-form.tsx +++ b/web/components/config/video-variant-form.tsx @@ -79,18 +79,18 @@ export default function VideoVariantForm({ }; const handleScaledWidthChanged = (args: UpdateArgs) => { const value = Number(args.value); - if (!isNaN(value)) { + if (isNaN(value)) { return; } - onUpdateField({ fieldName: 'scaledWidth', value: value }); + onUpdateField({ fieldName: 'scaledWidth', value: value || '' }); }; const handleScaledHeightChanged = (args: UpdateArgs) => { const value = Number(args.value); - if (!isNaN(value)) { + if (isNaN(value)) { return; } - onUpdateField({ fieldName: 'scaledHeight', value: value }); + onUpdateField({ fieldName: 'scaledHeight', value: value || '' }); }; const framerateDefaults = VIDEO_VARIANT_DEFAULTS.framerate; const framerateMin = framerateDefaults.min; From 64b41c4a5710034340301c36984d144be42e0bbe Mon Sep 17 00:00:00 2001 From: Gabe Kangas Date: Sun, 7 Feb 2021 21:33:11 -0800 Subject: [PATCH 2/2] Update description to mention where the new logo is stored, data dir --- web/utils/config-constants.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/utils/config-constants.tsx b/web/utils/config-constants.tsx index bbca05014..54588e160 100644 --- a/web/utils/config-constants.tsx +++ b/web/utils/config-constants.tsx @@ -81,7 +81,7 @@ export const TEXTFIELD_PROPS_LOGO = { placeholder: '/img/mylogo.png', label: 'Logo', tip: - 'Path to your logo from website root. We recommend that you use a square image that is at least 256x256. (upload functionality coming soon)', + 'Name of your logo in the data directory. We recommend that you use a square image that is at least 256x256.', }; export const TEXTFIELD_PROPS_STREAM_KEY = { apiPath: API_STREAM_KEY,