Start cleaning up linter errors. (#358)

* Start cleaning up linter errors. For #357

* Fix unmarshalling NullTime values

* More linter fixes

* Remove commented code

* Move defer up

* Consolidate error check lines

* Move error check to make sure row iteration was successful

* Cleaner error check + do not recreate pipe if it exists

* Consolidate hashing to generate client id
This commit is contained in:
Gabe Kangas
2020-11-14 18:39:53 -08:00
committed by GitHub
parent c76b7229a5
commit 4d2066a76d
34 changed files with 248 additions and 143 deletions

View File

@@ -27,7 +27,7 @@ func ServeAdmin(w http.ResponseWriter, r *http.Request) {
f, err := pkger.Open(path)
if err != nil {
log.Warnln(err, path)
errorHandler(w, r, http.StatusNotFound)
errorHandler(w, http.StatusNotFound)
return
}
@@ -39,9 +39,11 @@ func ServeAdmin(w http.ResponseWriter, r *http.Request) {
mimeType := mime.TypeByExtension(filepath.Ext(path))
w.Header().Set("Content-Type", mimeType)
w.Write(b)
if _, err = w.Write(b); err != nil {
log.Errorln(err)
}
}
func errorHandler(w http.ResponseWriter, r *http.Request, status int) {
func errorHandler(w http.ResponseWriter, status int) {
w.WriteHeader(status)
}