Start cleaning up linter errors. (#358)

* Start cleaning up linter errors. For #357

* Fix unmarshalling NullTime values

* More linter fixes

* Remove commented code

* Move defer up

* Consolidate error check lines

* Move error check to make sure row iteration was successful

* Cleaner error check + do not recreate pipe if it exists

* Consolidate hashing to generate client id

core/chat/persistence.go

@@ -32,7 +32,10 @@ func createTable() {
 		log.Fatal(err)
 	}
 	defer stmt.Close()
-	stmt.Exec()
+	_, err = stmt.Exec()
+	if err != nil {
+		log.Warnln(err)
+	}
 }
 
 func addMessage(message models.ChatMessage) {
@@ -41,16 +44,20 @@ func addMessage(message models.ChatMessage) {
 		log.Fatal(err)
 	}
 	stmt, err := tx.Prepare("INSERT INTO messages(id, author, body, messageType, visible, timestamp) values(?, ?, ?, ?, ?, ?)")
+
 	if err != nil {
 		log.Fatal(err)
 	}
+	defer stmt.Close()
+
 	_, err = stmt.Exec(message.ID, message.Author, message.Body, message.MessageType, 1, message.Timestamp)
 	if err != nil {
 		log.Fatal(err)
 	}
-	tx.Commit()
-
-	defer stmt.Close()
+	err = tx.Commit()
+	if err != nil {
+		log.Fatal(err)
+	}
 }
 
 func getChatHistory() []models.ChatMessage {
@@ -89,5 +96,9 @@ func getChatHistory() []models.ChatMessage {
 		history = append(history, message)
 	}
 
+	if err := rows.Err(); err != nil {
+		log.Fatal(err)
+	}
+
 	return history
 }