0

add a delay before recalculating vh 😭

This commit is contained in:
Ginger Wong 2020-06-15 15:55:57 -07:00
parent 0510d47486
commit 59ab5e9e98
4 changed files with 7 additions and 7 deletions

View File

@ -30,6 +30,7 @@ problems;
- chat windwo placementis messedup on orientation changes.. needs new vh. - chat windwo placementis messedup on orientation changes.. needs new vh.
orientationchange oly happens on mobile. orientationchange oly happens on mobile.
does orientationchange happen when keyboard appears? does orientationchange happen when keyboard appears?
- changing vh after orientation change sometimes yields same value
possible hacks possible hacks
- if mobile, don't show chat + chat icon in landscape?.. - if mobile, don't show chat + chat icon in landscape?..

View File

@ -28,9 +28,8 @@ function setupApp() {
// style hackings // style hackings
window.VIDEOJS_NO_DYNAMIC_STYLE = true; window.VIDEOJS_NO_DYNAMIC_STYLE = true;
if (hasTouchScreen()) { if (hasTouchScreen()) {
mobileVHhack(); setVHvar();
window.onorientationchange = handleOrientationChange; window.onorientationchange = handleOrientationChange;
// document.addEventListener("orientationchange", handleOrientationChange);
} }

View File

@ -99,11 +99,11 @@ class Messaging {
handleKeyboardAppear() { handleKeyboardAppear() {
this.tagAppContainer.classList.add("android-message-focus"); this.tagAppContainer.classList.add("android-message-focus");
setVHvar(); mobileVHhack();
} }
handleKeyboardOut() { handleKeyboardOut() {
this.tagAppContainer.classList.remove("android-message-focus"); this.tagAppContainer.classList.remove("android-message-focus");
setVHvar(); mobileVHhack();
} }
handleChatToggle() { handleChatToggle() {

View File

@ -44,9 +44,9 @@ function setVHvar() {
document.documentElement.style.setProperty('--vh', `${vh}px`); document.documentElement.style.setProperty('--vh', `${vh}px`);
console.log("== new vh", vh) console.log("== new vh", vh)
} }
// delayed
function mobileVHhack() { function mobileVHhack() {
setVHvar(); setTimeout(setVHvar, 100);
// window.addEventListener("orientationchange", setVHvar);
} }
function isAndroidMobile() { function isAndroidMobile() {
@ -83,5 +83,5 @@ function hasTouchScreen() {
function handleOrientationChange(event) { function handleOrientationChange(event) {
console.log("====orientation change 123", event, window.screen.orientation, window.orientation) console.log("====orientation change 123", event, window.screen.orientation, window.orientation)
setVHvar(); mobileVHhack();
} }