style fix for error checking (#1170)

+additional linting

core/data/accessTokens.go

@@ -25,8 +25,7 @@ func createAccessTokensTable() {
 		log.Fatal(err)
 	}
 	defer stmt.Close()
-	_, err = stmt.Exec()
-	if err != nil {
+	if _, err := stmt.Exec(); err != nil {
 		log.Warnln(err)
 	}
 }
@@ -48,7 +47,7 @@ func InsertToken(token string, name string, scopes []string) error {
 	}
 	defer stmt.Close()
 
-	if _, err = stmt.Exec(token, name, scopesString); err != nil {
+	if _, err := stmt.Exec(token, name, scopesString); err != nil {
 		return err
 	}
 

core/data/data_test.go

@@ -16,8 +16,7 @@ func TestString(t *testing.T) {
 	const testKey = "test string key"
 	const testValue = "test string value"
 
-	err := _datastore.SetString(testKey, testValue)
-	if err != nil {
+	if err := _datastore.SetString(testKey, testValue); err != nil {
 		panic(err)
 	}
 

core/data/webhooks.go

@@ -26,8 +26,7 @@ func createWebhooksTable() {
 		log.Fatal(err)
 	}
 	defer stmt.Close()
-	_, err = stmt.Exec()
-	if err != nil {
+	if _, err = stmt.Exec(); err != nil {
 		log.Warnln(err)
 	}
 }
@@ -126,8 +125,7 @@ func GetWebhooksForEvent(event models.EventType) []models.Webhook {
 	for rows.Next() {
 		var url string
 
-		err = rows.Scan(&url, &event)
-		if err != nil {
+		if err := rows.Scan(&url, &event); err != nil {
 			log.Debugln(err)
 			log.Error("There is a problem with the database.")
 			break