Fix all golangci-lint warnings surfaced by v2.4.0 (#4567)

* Initial plan

* Fix all golangci-lint warnings (21 issues resolved)

Co-authored-by: gabek <414923+gabek@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: gabek <414923+gabek@users.noreply.github.com>
This commit is contained in:
Copilot
2025-09-25 20:03:40 -07:00
committed by GitHub
co-authored by gabek copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
parent 19a4593a12
commit a0066fcf54
12 changed files with 60 additions and 63 deletions
+1 -1
View File
@@ -11,7 +11,7 @@ import (
func GetURLParam(r *http.Request, key string) (value string, err error) {
value = chi.URLParam(r, key)
if value == "" {
err = errors.New("Request does not contain requested URL param")
err = errors.New("request does not contain requested URL param")
}
return
}
+9 -8
View File
@@ -78,23 +78,23 @@ func Move(source, destination string) error {
func moveFallback(source, destination string) error {
inputFile, err := os.Open(source) // nolint: gosec
if err != nil {
return fmt.Errorf("Couldn't open source file: %s", err)
return fmt.Errorf("couldn't open source file: %s", err)
}
outputFile, err := os.Create(destination) // nolint: gosec
if err != nil {
_ = inputFile.Close()
return fmt.Errorf("Couldn't open dest file: %s", err)
return fmt.Errorf("couldn't open dest file: %s", err)
}
defer outputFile.Close()
_, err = io.Copy(outputFile, inputFile)
_ = inputFile.Close()
if err != nil {
return fmt.Errorf("Writing to output file failed: %s", err)
return fmt.Errorf("writing to output file failed: %s", err)
}
// The copy was successful, so now delete the original file
err = os.Remove(source)
if err != nil {
return fmt.Errorf("Failed removing original file: %s", err)
return fmt.Errorf("failed removing original file: %s", err)
}
return nil
}
@@ -438,13 +438,14 @@ func DecodeBase64Image(url string) (bytes []byte, extension string, err error) {
contentType := strings.Split(splitHeader[1], ";")[0]
if contentType == "image/svg+xml" {
switch contentType {
case "image/svg+xml":
extension = ".svg"
} else if contentType == "image/gif" {
case "image/gif":
extension = ".gif"
} else if contentType == "image/png" {
case "image/png":
extension = ".png"
} else if contentType == "image/jpeg" {
case "image/jpeg":
extension = ".jpeg"
}