LogalDeveloper/owncast
0
Fork 0
Code Activity

Update standard-pull-request.md

Browse Source
This commit is contained in:
Gabe Kangas
2025-05-16 09:49:19 -07:00
committed by GitHub
parent f97954edca
commit a13bca35d8
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/PULL_REQUEST_TEMPLATE/standard-pull-request.md
+12 -4
View File
@@ -2,15 +2,22 @@
## We manage everything through issues, not PRs.
If this is an unsolicited change, or there is no existing issue filed for it, **please open a GitHub issue before creating a pull request**. This will allow us to discuss the motivations and the big picture behind the change first. It's possible there may be other solutions that should be discussed for what you think should be built. It is possible your change will be rejected unless some discussion around your proposal happens first. While creating this PR means you probably already did the work, **it still makes sense to file an issue now**, and into the future when you have proposed changes.
A PR is a **solution**. A solution without a **problem** breaks release notes. **Please open an issue** so the list of problems that were fixed can be correctly listed and be attributed to you.
A PR is a solution. A solution without a problem breaks release notes. **Please open an issue** so the list of problems that were fixed can be correctly listed.
If this is an unsolicited change, or there is no existing issue filed for it, **please open a GitHub issue before creating a pull request**. This will allow us to discuss the motivations and the big picture behind the change first. It's possible there may be other solutions that should be discussed for what you think should be built. It is possible your change will be rejected unless some discussion around your proposal happens first. While creating this PR means you probably already did the work, **it still makes sense to file an issue now**, and into the future when you have proposed changes.
Additionally, when attributing credit in releases, we use issues to determine who worked on each version. If there isn't an issue assigned to you, you may not get credit in release notes.
## Resources
- [Developing Owncast](https://docs.owncast.dev/development)
- [How We Develop Frontend React Components](https://docs.owncast.dev/develop-frontend-components)
- [Supporting Translations](https://owncast.notion.site/web-translations)
## Description
Please include a summary of the change and which issue number is fixed, including relevant motivation and context. Feel free to mark this as a Draft or WIP and write up some details later and start a conversation, even if your PR is not ready for review.
Once there is an issue filed, a PR can be linked to it.
Please include a summary of the change in the PR and which issue number is fixed, including relevant motivation and context. Mark this as a Draft or WIP and write up some details later and start a conversation, even if your PR is not ready for review or you haven't yet provided all the information.
Fixes # (issue)
@@ -26,5 +33,6 @@ Some things you might want to mention:
2. Explain how it works and decisions you made.
3. If you're fixing something, what was wrong? How should we stop from having this issue happen again?
4. If this is a new feature or addition to functionality, why should it be added? What are the use cases? Who was asking for this functionality?
5. If this is a frontend change, does the text support [translation](https://owncast.notion.site/web-translations)?
Thank you so much for contributing to Owncast! 🎉