LogalDeveloper/owncast
0
Fork 0
Code Activity

Add a layer of safety around required ActivityPub Actor fields (#4703)

Browse Source 
* fix(ap): add safe constructors, getters, and validators to ActivityPub actors to address #4701

* chore: replace nil check with the new Validate() method

* chore(test): added test to verify the values extracted from actors

* fix: return the specific error type + test for it

* fix(ap): add recovery for each AP inbox worker for a worst case scenario

* fix(ap): add additional safe accessor methods to other AP entities other than actors

* chore(tests): add tests for the new safe accessors

* fix(ap): handle empty public keys in AP actors
This commit is contained in:
Gabe Kangas
2026-01-17 14:25:06 -08:00
committed by GitHub
parent 0ff73d5e1e
commit a82efb0e9a
19 changed files with 1671 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files
activitypub/resolvers/follow.go
+2 -2
View File
@@ -18,10 +18,10 @@ func getPersonFromFollow(activity vocab.ActivityStreamsFollow) (apmodels.Activit
func MakeFollowRequest(c context.Context, activity vocab.ActivityStreamsFollow) (*apmodels.ActivityPubActor, error) {
person, err := getPersonFromFollow(activity)
if err != nil {
return nil, errors.New("unable to resolve person from follow request: " + err.Error())
return nil, errors.Wrap(err, "unable to resolve person from follow request")
}
hostname := person.ActorIri.Hostname()
hostname := person.ActorIriHostname()
username := person.Username
fullUsername := fmt.Sprintf("%s@%s", username, hostname)