From aefe884dafd5add6a3c01faaca437e7c0e5fd184 Mon Sep 17 00:00:00 2001
From: Gabe Kangas <gabek@real-ity.com>
Date: Mon, 22 Mar 2021 20:43:25 -0700
Subject: [PATCH] Stop leaking instances via links. Closes
 https://github.com/owncast/owncast/issues/822

---
 web/pages/actions.tsx     | 16 +++++++++-------
 web/pages/viewer-info.tsx | 10 ++++++++--
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/web/pages/actions.tsx b/web/pages/actions.tsx
index 9e4f1cb91..f6eb87d4a 100644
--- a/web/pages/actions.tsx
+++ b/web/pages/actions.tsx
@@ -73,8 +73,13 @@ function NewActionModal(props: Props) {
       okButtonProps={okButtonProps}
     >
       <div>
-        Add the URL for the external action you want to present.  <strong>Only HTTPS urls are supported.</strong>
-        <p><a href="https://owncast.online/docs">Read more about external actions.</a></p>
+        Add the URL for the external action you want to present.{' '}
+        <strong>Only HTTPS urls are supported.</strong>
+        <p>
+          <a href="https://owncast.online/docs" target="_blank" rel="noopener noreferrer">
+            Read more about external actions.
+          </a>
+        </p>
         <p>
           <Input
             value={actionUrl}
@@ -91,7 +96,6 @@ function NewActionModal(props: Props) {
             onChange={input => setActionTitle(input.currentTarget.value)}
           />
         </p>
-
         <p>
           <Input
             value={actionDescription}
@@ -99,7 +103,6 @@ function NewActionModal(props: Props) {
             onChange={input => setActionDescription(input.currentTarget.value)}
           />
         </p>
-
         <p>
           <Input
             value={actionIcon}
@@ -107,7 +110,6 @@ function NewActionModal(props: Props) {
             onChange={input => setActionIcon(input.currentTarget.value)}
           />
         </p>
-
         <p>
           <Input
             type="color"
@@ -116,7 +118,6 @@ function NewActionModal(props: Props) {
           />
           Optional background color of the action button.
         </p>
-
         <Checkbox
           checked={openExternally}
           defaultChecked={openExternally}
@@ -279,7 +280,8 @@ export default function Actions() {
       <Paragraph>Description goes here.</Paragraph>
       <Paragraph>
         Read more about how to use actions, with examples, at{' '}
-        <a href="https://owncast.online/thirdparty/?source=admin">our documentation</a>.
+        <a href="https://owncast.online/thirdparty/?source=admin" target="_blank"
+          rel="noopener noreferrer">our documentation</a>.
       </Paragraph>
 
       <Table rowKey="id" columns={columns} dataSource={actions} pagination={false} />
diff --git a/web/pages/viewer-info.tsx b/web/pages/viewer-info.tsx
index 9a6c1ffda..fcf5f130b 100644
--- a/web/pages/viewer-info.tsx
+++ b/web/pages/viewer-info.tsx
@@ -130,8 +130,14 @@ export default function ViewersOverTime() {
           <p>
             <Typography.Text type="secondary">
               Visit the{' '}
-              <a href="https://owncast.online/docs/viewers/?source=admin">documentation</a> to
-              configure additional details about your viewers.
+              <a
+                href="https://owncast.online/docs/viewers/?source=admin"
+                target="_blank"
+                rel="noopener noreferrer"
+              >
+                documentation
+              </a>{' '}
+              to configure additional details about your viewers.
             </Typography.Text>{' '}
           </p>
         </div>