Migrate forbidden and suggested usernames list to string slice. Closes #1873

core/data/datastoreMigrations.go

@@ -0,0 +1,49 @@
+package data
+
+import (
+	"strings"
+
+	log "github.com/sirupsen/logrus"
+)
+
+const (
+	datastoreValuesVersion   = 1
+	datastoreValueVersionKey = "DATA_STORE_VERSION"
+)
+
+func migrateDatastoreValues(datastore *Datastore) {
+	currentVersion, _ := _datastore.GetNumber(datastoreValueVersionKey)
+
+	for v := currentVersion; v < datastoreValuesVersion; v++ {
+		log.Tracef("Migration datastore values from %d to %d\n", int(v), int(v+1))
+		switch v {
+		case 0:
+			migrateToDatastoreValues1(datastore)
+		default:
+			log.Fatalln("missing datastore values migration step")
+		}
+	}
+	if err := _datastore.SetNumber(datastoreValueVersionKey, datastoreValuesVersion); err != nil {
+		log.Errorln("error setting datastore value version:", err)
+	}
+}
+
+func migrateToDatastoreValues1(datastore *Datastore) {
+	// Migrate the forbidden usernames to be a slice instead of a string.
+	forbiddenUsernamesString, _ := datastore.GetString(blockedUsernamesKey)
+	if forbiddenUsernamesString != "" {
+		forbiddenUsernamesSlice := strings.Split(forbiddenUsernamesString, ",")
+		if err := datastore.SetStringSlice(blockedUsernamesKey, forbiddenUsernamesSlice); err != nil {
+			log.Errorln("error migrating blocked username list:", err)
+		}
+	}
+
+	// Migrate the suggested usernames to be a slice instead of a string.
+	suggestedUsernamesString, _ := datastore.GetString(suggestedUsernamesKey)
+	if suggestedUsernamesString != "" {
+		suggestedUsernamesSlice := strings.Split(suggestedUsernamesString, ",")
+		if err := datastore.SetStringSlice(suggestedUsernamesKey, suggestedUsernamesSlice); err != nil {
+			log.Errorln("error migrating suggested username list:", err)
+		}
+	}
+}