Some linter cleanup

core/chat/chatclient.go

@@ -118,7 +118,7 @@ func (c *Client) readPump() {
 			continue
 		}
 
-		message = bytes.TrimSpace(bytes.Replace(message, newline, space, -1))
+		message = bytes.TrimSpace(bytes.ReplaceAll(message, newline, space))
 		c.handleEvent(message)
 	}
 }

core/chat/events.go

@@ -111,6 +111,6 @@ func (s *Server) userMessageSent(eventData chatClientEvent) {
 
 	SaveUserMessage(event)
 
-	eventData.client.MessageCount = eventData.client.MessageCount + 1
+	eventData.client.MessageCount++
 	_lastSeenCache[event.User.ID] = time.Now()
 }

core/chat/utils.go

@@ -2,6 +2,7 @@ package chat
 
 import (
 	"syscall"
+
 	log "github.com/sirupsen/logrus"
 )
 

core/transcoder/thumbnailGenerator.go

@@ -132,10 +132,8 @@ func makeAnimatedGifPreview(sourceFile string, outputFile string) {
 	ffmpegCmd := strings.Join(animatedGifFlags, " ")
 	if _, err := exec.Command("sh", "-c", ffmpegCmd).Output(); err != nil {
 		log.Errorln(err)
-	} else {
 		// rename temp file
-		if err := os.Rename(outputFileTemp, outputFile); err != nil {
-			log.Errorln(err)
-		}
+	} else if err := os.Rename(outputFileTemp, outputFile); err != nil {
+		log.Errorln(err)
 	}
 }

core/transcoder/transcoder.go

@@ -284,9 +284,8 @@ func (t *Transcoder) getVariantsString() string {
 
 	for _, variant := range t.variants {
 		variantsCommandFlags = variantsCommandFlags + " " + variant.getVariantString(t)
-		singleVariantMap := ""
-		singleVariantMap = fmt.Sprintf("v:%d,a:%d ", variant.index, variant.index)
-		variantsStreamMaps = variantsStreamMaps + singleVariantMap
+		singleVariantMap := fmt.Sprintf("v:%d,a:%d ", variant.index, variant.index)
+		variantsStreamMaps += singleVariantMap
 	}
 	variantsCommandFlags = variantsCommandFlags + " " + variantsStreamMaps + "\""