LogalDeveloper/owncast
0
Fork 0
Code Activity

Address some layout issues with odd content spacing on mobile, and footer position (#3022)

Browse Source 
* - set vars for player container height and status bar height
- use them to calculate mobile top spacing to adjust for tab content positioning

* give main content section a min height, place footer absolutely at bottom; rm all the fixed footer styling

* cleanup; restructure tabbed display logic and css a bit

* Prettified Code!

* cleanup

* fix(story): footer story needs to be wrapped in RecoilRoot if it is to use Recoil

* revert adding footer to mobile about section

* prevent double scrolling

---------

Co-authored-by: gingervitis <gingervitis@users.noreply.github.com>
Co-authored-by: Gabe Kangas <gabek@real-ity.com>
This commit is contained in:
gingervitis
2023-05-18 12:13:26 -07:00
committed by GitHub
parent d675713e2c
commit c2a0295a0c
11 changed files with 88 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
web/components/video/OwncastPlayer/OwncastPlayer.module.scss
View File

@@ -4,12 +4,12 @@
display: grid;
width: 100%;
justify-items: center;
height: 75vh;
height: var(--player-container-height);
aspect-ratio: 16 / 9;
@media (max-width: 1200px) {
height: 100%;
max-height: 75vh;
max-height: var(--player-container-height);
}
@include screen(desktop) {
@@ -19,14 +19,8 @@
//set height of player for tablet
@include screen(tablet) {
height: 400px;
max-height: 400px;
}
//set height of player for mobile
@include screen(mobile) {
height: 250px;
max-height: 250px;
height: var(--player-container-height);
max-height: var(--player-container-height);
}
.player,