add shellcheck to CI (#2478)

* add shellcheck to ci

* test ci

* install bash for shellcheck

* set globstar for bash

* cleanup shell scripts

* do not ignore automated hls tests

* rm legacy build script

* update shell scripts

* cleanup ci

* Fix misspell

* cleanup ci

* fail on curl error in ci

.github/workflows/go-lint.yml

@@ -1,4 +1,4 @@
-name: lint
+name: Lint
 on:
   push:
     paths-ignore:

.github/workflows/javascript-formatting.yml

@@ -1,4 +1,4 @@
-name: Format+Lint Javascript
+name: Lint
 
 # This action works with pull requests and pushes
 on:
@@ -11,7 +11,7 @@ on:
 
 jobs:
   prettier:
-    name: Run prettier
+    name: Javascript prettier
     runs-on: ubuntu-latest
     defaults:
       run:
@@ -42,7 +42,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   linter:
-    name: Run linter on changed files
+    name: Javascript linter
     runs-on: ubuntu-latest
     defaults:
       run:

.github/workflows/shellcheck.yml

@@ -0,0 +1,30 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - webv2
+    paths:
+      - '**.sh'
+  pull_request:
+    branches:
+      - webv2
+    paths:
+      - '**.sh'
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    env:
+      LANG: C.UTF-8
+    container:
+      image: docker.io/ubuntu:22.04
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install shellcheck
+        run: apt update && apt install -y shellcheck bash && shellcheck --version
+
+      - name: Check shell scripts
+        run: shopt -s globstar && ls **/*.sh && shellcheck --severity=info **/*.sh
+        shell: bash