add shellcheck to CI (#2478)

* add shellcheck to ci

* test ci

* install bash for shellcheck

* set globstar for bash

* cleanup shell scripts

* do not ignore automated hls tests

* rm legacy build script

* update shell scripts

* cleanup ci

* Fix misspell

* cleanup ci

* fail on curl error in ci

build/release/build.sh

@@ -1,118 +0,0 @@
-#!/bin/sh
-
-# Human readable names of binary distributions
-DISTRO=(macOS-64bit linux-64bit linux-32bit linux-arm7 linux-arm64)
-# Operating systems for the respective distributions
-OS=(darwin linux linux linux linux)
-# Architectures for the respective distributions
-ARCH=(amd64 amd64 386 arm-7 arm64)
-
-# Version
-VERSION=$1
-SHOULD_RELEASE=$2
-
-# Build info
-GIT_COMMIT=$(git rev-list -1 HEAD)
-GIT_BRANCH=$(git rev-parse --abbrev-ref HEAD)
-
-if [[ -z "${VERSION}" ]]; then
-  echo "Version must be specified when running build"
-  exit
-fi
-
-BUILD_TEMP_DIRECTORY="$(mktemp -d)"
-cd $BUILD_TEMP_DIRECTORY
-
-echo "Cloning owncast into $BUILD_TEMP_DIRECTORY..."
-git clone https://github.com/owncast/owncast 2> /dev/null
-cd owncast
-
-echo "Changing to branch: $GIT_BRANCH"
-git checkout $GIT_BRANCH
-
-[[ -z "${VERSION}" ]] && VERSION='unknownver' || VERSION="${VERSION}"
-
-# Change to the root directory of the repository
-cd $(git rev-parse --show-toplevel)
-
-echo "Cleaning working directories..."
-rm -rf ./webroot/hls/* ./hls/* ./webroot/thumbnail.jpg
-
-echo "Creating version ${VERSION} from commit ${GIT_COMMIT}"
-
-# Create production build of Tailwind CSS
-pushd build/javascript >> /dev/null
-# Install the tailwind & postcss CLIs
-npm install --quiet --no-progress
-# Run the tailwind CLI and pipe it to postcss for minification.
-# Save it to a temp directory that we will reference below.
-NODE_ENV="production" ./node_modules/.bin/tailwind build | ./node_modules/.bin/postcss >  "${TMPDIR}tailwind.min.css"
-popd
-
-mkdir -p dist
-
-build() {
-  NAME=$1
-  OS=$2
-  ARCH=$3
-  VERSION=$4
-  GIT_COMMIT=$5
-
-  echo "Building ${NAME} (${OS}/${ARCH}) release from ${GIT_BRANCH} ${GIT_COMMIT}..."
-
-  mkdir -p dist/${NAME}
-  mkdir -p dist/${NAME}/data
-
-  cp -R webroot/ dist/${NAME}/webroot/
-
-  # Copy the production pruned+minified css to the build's directory.
-  cp "${TMPDIR}tailwind.min.css" ./dist/${NAME}/webroot/js/web_modules/tailwindcss/dist/tailwind.min.css
-  cp README.md dist/${NAME}
-
-  pushd dist/${NAME} >> /dev/null
-
-  CGO_ENABLED=1 ~/go/bin/xgo -go latest --branch ${GIT_BRANCH} -ldflags "-s -w -X github.com/owncast/owncast/config.GitCommit=${GIT_COMMIT} -X github.com/owncast/owncast/config.BuildVersion=${VERSION} -X github.com/owncast/owncast/config.BuildPlatform=${NAME}" -tags enable_updates -targets "${OS}/${ARCH}" github.com/owncast/owncast
-  mv owncast-*-${ARCH} owncast
-
-  zip -r -q -8 ../owncast-$VERSION-$NAME.zip .
-  popd >> /dev/null
-
-  rm -rf dist/${NAME}/
-}
-
-for i in "${!DISTRO[@]}"; do
-  build ${DISTRO[$i]} ${OS[$i]} ${ARCH[$i]} $VERSION $GIT_COMMIT
-done
-
-echo "Build archives are available in $BUILD_TEMP_DIRECTORY/owncast/dist"
-ls -alh "$BUILD_TEMP_DIRECTORY/owncast/dist"
-
-# Use the second argument "release" to create an actual release.
-if [ "$SHOULD_RELEASE" != "release" ]; then
-  echo "Not uploading a release."
-  exit
-fi
-
-# Create the tag
-git tag -a "v${VERSION}" -m "Release build v${VERSION}"
-
-# On macOS open the Github page for new releases so they can be uploaded
-if test -f "/usr/bin/open"; then
-  open "https://github.com/owncast/owncast/releases/new"
-  open dist
-fi
-
-# Docker build
-# Must authenticate first: https://docs.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-docker-for-use-with-github-packages#authenticating-to-github-packages
-DOCKER_IMAGE="owncast-${VERSION}"
-echo "Building Docker image ${DOCKER_IMAGE}..."
-
-# Change to the root directory of the repository
-cd $(git rev-parse --show-toplevel)
-
-# Docker build
-docker build --build-arg NAME=docker --build-arg VERSION=${VERSION} --build-arg GIT_COMMIT=$GIT_COMMIT -t gabekangas/owncast:$VERSION -t gabekangas/owncast:latest -t owncast .
-
-# Dockerhub
-# You must be authenticated via `docker login` with your Dockerhub credentials first.
-docker push "gabekangas/owncast:${VERSION}"

build/release/docker-nightly.sh

@@ -9,6 +9,6 @@ VERSION="${DATE}-nightly"
 echo "Building Docker image ${DOCKER_IMAGE}..."
 
 # Change to the root directory of the repository
-cd $(git rev-parse --show-toplevel)
+cd "$(git rev-parse --show-toplevel)" || exit
 
 earthly --ci --push +docker-all --image="ghcr.io/owncast/${DOCKER_IMAGE}" --tag=nightly --version="${VERSION}"

build/release/docker-webv2.sh

@@ -9,7 +9,7 @@ VERSION="${DATE}-${TAG}"
 echo "Building Docker image ${DOCKER_IMAGE}..."
 
 # Change to the root directory of the repository
-cd $(git rev-parse --show-toplevel)
+cd "$(git rev-parse --show-toplevel)" || exit
 git checkout webv2
 
-earthly --ci --push +docker-all --image="ghcr.io/owncast/${DOCKER_IMAGE}" --tag=${TAG} --version="${VERSION}"
+earthly --ci --push +docker-all --image="ghcr.io/owncast/${DOCKER_IMAGE}" --tag="${TAG}" --version="${VERSION}"