LogalDeveloper/owncast
0
Fork 0
Code Activity

Transcoder updates for bitrate validator warnings (#106)

Browse Source 
* Transcoder updates for validator warnings (gop, max-bitrates) for #50

* Make the variant settings easier to set/read in code

* Update test to reflect update to transcoder

* Reduce the buffer to give it a little more room to improve the quality. It feels a bit crunched right now.

* Fix test due to changed bitrate buffer ratios

* Tweak buffer size one more time to get errors in the validator to zero

* Saw errors w/ different bitrates, so tweaking it again
This commit is contained in:
Gabe Kangas
2020-08-06 12:19:35 -07:00
committed by GitHub
parent df04af0f38
commit d21f136120
4 changed files with 45 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/ffmpeg/transcoder_test.go
View File

@@ -13,7 +13,7 @@ func TestFFmpegCommand(t *testing.T) {
transcoder.SetHLSPlaylistLength(10)
variant := HLSVariant{}
variant.videoBitrate = "1200k"
variant.videoBitrate = 1200
variant.isAudioPassthrough = true
variant.encoderPreset = "veryfast"
variant.SetVideoFramerate(30)
@@ -22,7 +22,7 @@ func TestFFmpegCommand(t *testing.T) {
cmd := transcoder.getString()
expected := "cat fakecontent.flv | /fake/path/ffmpeg -hide_banner -i pipe: -map v:0 -c:v:0 libx264 -b:v:0 1200k -map a:0 -c:a:0 copy -r 30 -g 60 -keyint_min 60 -preset veryfast -var_stream_map \"v:0,a:0 \" -f hls -hls_time 4 -hls_list_size 10 -hls_delete_threshold 10 -hls_flags delete_segments+program_date_time+temp_file -tune zerolatency -sc_threshold 0 -master_pl_name stream.m3u8 -strftime 1 -hls_segment_filename fakeOutput/%v/stream-%s.ts -max_muxing_queue_size 400 fakeOutput/%v/stream.m3u8 2> transcoder.log"
expected := `cat fakecontent.flv | /fake/path/ffmpeg -hide_banner -i pipe: -map v:0 -c:v:0 libx264 -b:v:0 1200k -maxrate:v:0 1272k -bufsize:v:0 1440k -g:v:0 119 -x264-params:v:0 "scenecut=0:open_gop=0:min-keyint=119:keyint=119" -map a:0 -c:a:0 copy -r 30 -preset veryfast -var_stream_map "v:0,a:0 " -f hls -hls_time 4 -hls_list_size 10 -hls_delete_threshold 10 -hls_flags delete_segments+program_date_time+temp_file -tune zerolatency -sc_threshold 0 -master_pl_name stream.m3u8 -strftime 1 -hls_segment_filename fakeOutput/%v/stream-%s.ts -max_muxing_queue_size 400 fakeOutput/%v/stream.m3u8 2> transcoder.log`
if cmd != expected {
t.Errorf("ffmpeg command does not match expected. Got %s, want: %s", cmd, expected)