use randomString/Number from lib in api tests (#2542)

test/automated/api/chat.test.js

@@ -5,9 +5,10 @@ request = request('http://127.0.0.1:8080');
 const registerChat = require('./lib/chat').registerChat;
 const sendChatMessage = require('./lib/chat').sendChatMessage;
 const getAdminResponse = require('./lib/admin').getAdminResponse;
+const randomNumber = require('./lib/rand').randomNumber;
 
 var userDisplayName;
-const message = Math.floor(Math.random() * 100) + ' test 123';
+const message = randomNumber(100) + ' test 123';
 
 const testMessage = {
   body: message,

test/automated/api/chatmoderation.test.js

@@ -8,9 +8,10 @@ const sendChatMessage = require('./lib/chat').sendChatMessage;
 const getAdminResponse = require('./lib/admin').getAdminResponse;
 const sendAdminPayload = require('./lib/admin').sendAdminPayload;
 const sendAdminRequest = require('./lib/admin').sendAdminRequest;
+const randomNumber = require('./lib/rand').randomNumber;
 
 const testVisibilityMessage = {
-	body: 'message ' + Math.floor(Math.random() * 100),
+	body: 'message ' + randomNumber(100),
 	type: 'CHAT',
 };
 

test/automated/api/chatusers.test.js

@@ -9,13 +9,13 @@ const sendChatMessage = require('./lib/chat').sendChatMessage;
 const sendAdminRequest = require('./lib/admin').sendAdminRequest;
 const sendAdminPayload = require('./lib/admin').sendAdminPayload;
 const getAdminResponse = require('./lib/admin').getAdminResponse;
-
+const randomNumber = require('./lib/rand').randomNumber;
 
 const localIPAddressV4 = '127.0.0.1';
 const localIPAddressV6 = '::1';
 
 const testVisibilityMessage = {
-  body: 'message ' + Math.floor(Math.random() * 100),
+  body: 'message ' + randomNumber(100),
   type: 'CHAT',
 };
 

test/automated/api/configmanagement.test.js

@@ -1,10 +1,10 @@
 var request = require('supertest');
 
-const Random = require('crypto-random');
-
 const sendAdminRequest = require('./lib/admin').sendAdminRequest;
 const failAdminRequest = require('./lib/admin').failAdminRequest;
 const getAdminResponse = require('./lib/admin').getAdminResponse;
+const randomString = require('./lib/rand').randomString;
+const randomNumber = require('./lib/rand').randomNumber;
 
 request = request('http://127.0.0.1:8080');
 
@@ -82,7 +82,7 @@ const newStreamKeys = [
 ];
 const newAdminPassword = randomString();
 
-const latencyLevel = Random.range(0, 4);
+const latencyLevel = randomNumber(4);
 const appearanceValues = {
 	variable1: randomString(),
 	variable2: randomString(),
@@ -457,10 +457,3 @@ test('verify frontend status', (done) => {
 		});
 });
 
-function randomString(length = 20) {
-	return Random.value().toString(16).substr(2, length);
-}
-
-function randomNumber() {
-	return Random.range(0, 5);
-}

test/automated/api/lib/rand.js

@@ -0,0 +1,16 @@
+const crypto = require('crypto');
+const Random = require('crypto-random');
+
+//returns a random number in range of [1 - max]
+function randomNumber(max = 5) {
+	return Random.range(1, max);
+}
+
+//returns a random hex string
+function randomString(length = 20) {
+    const bytesCount = Math.ceil(length / 2);
+    return crypto.randomBytes(bytesCount).toString('hex').substring(0, length);
+}
+
+module.exports.randomNumber = randomNumber;
+module.exports.randomString = randomString;

test/automated/api/publicstatic.test.js

@@ -2,11 +2,11 @@ var request = require('supertest');
 request = request('http://127.0.0.1:8080');
 const fs = require('fs');
 const path = require('path');
+const randomString = require('./lib/rand').randomString;
 
 const publicPath = path.resolve(__dirname, '../../../public');
-const filename = randomString(20) + '.txt';
+const filename = randomString() + '.txt';
-const fileContent = randomString(8);
+const fileContent = randomString();
-
 
 test('random public static file does not exist', async (done) => {
 	request.get('/public/' + filename).expect(404);
@@ -49,11 +49,6 @@ test('public static file is persistent and not locked', async (done) => {
 	done();
 });
 
-
-function randomString(length) {
-	return Math.random().toString(36).substr(2, length);
-}
-
 function writeFileToPublic() {
 	fs.writeFileSync(
 		path.join(publicPath, filename),