LogalDeveloper/owncast
0
Fork 0
Code Activity

Update standard-pull-request.md

Browse Source 
Update the PR template again to state even stronger that I want people to open issues because it makes my life difficult if they don't.
This commit is contained in:
Gabe Kangas
2025-03-20 05:39:06 -07:00
committed by GitHub
parent 3e42cb9678
commit dc09dc17a4
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/PULL_REQUEST_TEMPLATE/standard-pull-request.md
+7 -1
View File
@@ -1,6 +1,12 @@
# Read first # Read first
If this is an unsolicited change, or there is no existing issue filed for it, please open a GitHub issue before creating a pull request. This will allow us to discuss the motivations and the big picture behind the change first. It's possible there may be other solutions that should be discussed for what you think should be built. It is possible your change will be rejected unless some discussion around your proposal happens first. While creating this PR means you probably already did the work, it still makes sense to file an issue now, and into the future when you have proposed changes. ## We manage everything through issues, not PRs.
If this is an unsolicited change, or there is no existing issue filed for it, **please open a GitHub issue before creating a pull request**. This will allow us to discuss the motivations and the big picture behind the change first. It's possible there may be other solutions that should be discussed for what you think should be built. It is possible your change will be rejected unless some discussion around your proposal happens first. While creating this PR means you probably already did the work, **it still makes sense to file an issue now**, and into the future when you have proposed changes.
A PR is a solution. A solution without a problem breaks release notes. **Please open an issue** so the list of problems that were fixed can be correctly listed.
Additionally, when attributing credit in releases, we use issues to determine who worked on each version. If there isn't an issue assigned to you, you may not get credit in release notes.
## Description ## Description