LogalDeveloper/owncast
0
Fork 0
Code Activity

Add more checking around ffmpeg version validation. closes #619

Browse Source
This commit is contained in:
Gabe Kangas
2021-01-11 18:31:15 -08:00
parent 9214135ea4
commit f9916207c8
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
config/verifyInstall.go
View File

@@ -7,6 +7,8 @@ import (
"os/exec" "os/exec"
"strings" "strings"
log "github.com/sirupsen/logrus"
"golang.org/x/mod/semver" "golang.org/x/mod/semver"
) )
@@ -37,14 +39,26 @@ func verifyFFMpegPath(path string) error {
response := string(out) response := string(out)
if response == "" { if response == "" {
fmt.Println(err)
return fmt.Errorf("unable to determine the version of your ffmpeg installation at %s. you may experience issues with video.", path) return fmt.Errorf("unable to determine the version of your ffmpeg installation at %s. you may experience issues with video.", path)
} }
responseComponents := strings.Split(response, " ") responseComponents := strings.Split(response, " ")
if len(responseComponents) < 3 {
log.Debugf("unable to determine the version of your ffmpeg installation at %s. you may experience issues with video.", path)
return nil
}
fullVersionString := responseComponents[2] fullVersionString := responseComponents[2]
versionString := "v" + strings.Split(fullVersionString, "-")[0] versionString := "v" + strings.Split(fullVersionString, "-")[0]
if !semver.IsValid(versionString) || semver.Compare(versionString, FfmpegSuggestedVersion) == -1 {
// Some builds of ffmpeg have wierd build numbers that we can't parse
if !semver.IsValid(versionString) {
log.Debugf("unable to determine if ffmpeg version %s is recent enough. if you experience issues with video you may want to look into updating", fullVersionString)
return nil
}
if semver.Compare(versionString, FfmpegSuggestedVersion) == -1 {
return fmt.Errorf("your %s version of ffmpeg at %s may be older than the suggested version of %s. you may experience issues with video.", versionString, path, FfmpegSuggestedVersion) return fmt.Errorf("your %s version of ffmpeg at %s may be older than the suggested version of %s. you may experience issues with video.", versionString, path, FfmpegSuggestedVersion)
} }