Finished login security, added mysql support and password hashing.

loginsecurity.py

@@ -1,32 +1,44 @@
 from helpers import *
+from passlib.hash import pbkdf2_sha256 as crypt
 from basecommands import simplecommand
-import bcrypt
+import time
-from time import time as now
+import threading
-import thread
+from secrets import *
+import mysqlhack
+from com.ziclix.python.sql import zxJDBC
+
 
 
 wait_time = 60 #seconds
 admin_perm = "utils.loginsecurity.admin"
-min_pass_length = 6
+min_pass_length = 8
-
-run_kick_thread = True
 blocked_events = ["block.BlockBreakEvent", "block.BlockPlaceEvent", "player.PlayerMoveEvent"]
-passwords       = open_json_file("loginpasswords", {})
-
-#if passwords == None: (set default value to None  ^^)
-#    Keep everyone from playing? (Insecure)
-
-withholdings    = {} #pname : jointime
 
 
-def save_passwords():
+logging_in = {}
-    save_json_file("loginpasswords", passwords)
 
 
 def matches(password, user):
-    hashed = passwords.get(uid(user))
+    hashed = get_pass(uid(user))
-    return bcrypt.hashpw(password, hashed) == hashed
+    return crypt.verify(password, hashed)
 
+@simplecommand("cgpass",
+	usage       = "<password> <new password>",
+	description = "Changes your password",
+	senderLimit = 0,
+	helpNoargs  = True)
+def change_pass_command(sender, command, label, args):
+    if not len(args) == 2:
+        return "&cInvalid arguments"
+    password = args[0]
+    new_password = args[1]
+    uuid = uid(sender)
+    if is_registered(uuid):
+        if matches(password, sender):
+            change_pass(uuid, crypt.encrypt(new_password, rounds=200000, salt_size=16))
+            return "&aPassword changed"
+        return "&cInvalid password!"
+    return "&cYou are not registered"
 
 @simplecommand("login",
         usage       = "<password>", 
@@ -34,88 +46,143 @@ def matches(password, user):
         senderLimit = 0, 
         helpNoargs  = True)
 def login_command(sender, command, label, args):
-    password = " ".join(args)
+    password = args[0]
     if matches(password, sender):
-        del withholdings[sender.getName()]
+        del logging_in[sender.getName()]
         return "&aLogged in successfully!"
     return "&cInvalid password"
 
-
 @simplecommand("register",
         usage       = "<password>",
         description = "Registers you with <password>. Next time you join, log in with /login",
         senderLimit = 0,
-        helpNoArgs  = True)
+        helpNoargs  = True)
 def register_command(sender, command, label, args):
-    uuid = uid(sender)
+    if len(args) > 1:
-    if uuid in passwords:
+        return "&cPassword can only be one word!"
+    uuid = str(uid(sender))
+    ######################### - delete after testing
+    conn = zxJDBC.connect(mysql_database, mysql_user, mysql_pass, "com.mysql.jdbc.Driver")
+    curs = conn.cursor()
+    curs.execute("SELECT EXISTS(SELECT * FROM secret WHERE 'uuid' = ?)",(uuid,)) 
+    results = curs.fetchall()
+    print results[0][0]
+    #########################
+    if is_registered(uuid):
         return "&cYou are already registered!"
-    password = " ".join(args)
+    password = args[0]
     if len(password) < min_pass_length:
-        return "&cThe password has to be made up of at least 8 characters!"
+        return "&cThe password has to be made up of at least %s characters!" % min_pass_length
-    hashed = bcrypt.hashpw(password, bcrypt.gensalt(16))
+    hashed = crypt.encrypt(password, rounds=200000, salt_size=16)
-    passwords[uuid] = hashed
+    create_pass(uuid, hashed)
     return "&cPassword set. Use /login <password> upon join."
 
-
 @simplecommand("rmpass",
         usage       = "<password>",
         description = "Removes your password if the password matches",
         senderLimit = 0,
-        helpNoArgs  = True)
+        helpNoargs  = True)
 def rmpass_command(sender, command, label, args):
+    if not is_registered(uid(sender)):
+        return "&cYou are not registered!"
     password = " ".join(args)
     if matches(password, sender):
-        del passwords[uuid(sender)]
+        delete_pass(uid(sender))
         return "&aPassword removed successfully. You will not be prompted anymore."
     return "&cInvalid password"
 
-
 @simplecommand("rmotherpass",
         aliases     = ["lacrmpass"],
         usage       = "<user>",
         description = "Removes password of <user> and sends them a notification",
-        helpNoArgs  = True)
+        helpNoargs  = True)
 def rmotherpass_command(sender, command, label, args):
+    if not sender.hasPermission(admin_perm):
+        noperm(sender)
+        return
     user = server.getOfflinePlayer(args[0])
-    if user:
+    if is_registered(uid(user)):
-        del passwords[uid(user)]
+        delete_pass(uid(user))
-        runas(server.getConsoleSender(), colorify("mail send %s &cYour password was reset by a staff member. Use &o/register&c to set a new one."))
+        runas(server.getConsoleSender(), colorify("mail send %s &cYour password was reset by a staff member. Use &6/register&c to set a new one." % sender.getDisplayName()))
         return "&sPassword of %s reset successfully" % user.getName()
-    return "&cThat player could not be found"
+    return "&cThat player could not be found (or is not registered)"
 
+def change_pass(uuid, pw):
+    conn = zxJDBC.connect(mysql_database, mysql_user, mysql_pass, "com.mysql.jdbc.Driver")
+    curs = conn.cursor()
+    curs.execute("UPDATE secret SET 'pass' = ? WHERE 'uuid' = ?", (pw,), (uuid,))
 
-@hook.event("player.PlayerJoinEvent", "highest")
+def get_pass(uuid):
+    conn = zxJDBC.connect(mysql_database, mysql_user, mysql_pass, "com.mysql.jdbc.Driver")
+    curs = conn.cursor()
+    curs.execute("SELECT pass FROM secret WHERE 'uuid' = ?", (uuid,))
+    results = curs.fetchall()
+    curs.close()
+    conn.close()
+    return results[0][0]
+
+def create_pass(uuid, pw):
+    conn = zxJDBC.connect(mysql_database, mysql_user, mysql_pass, "com.mysql.jdbc.Driver")
+    curs = conn.cursor()
+    curs.execute("INSERT INTO secret VALUES (?)", (uuid,pw,))
+    curs.close()
+    conn.close()
+
+def is_registered(uuid):
+    conn = zxJDBC.connect(mysql_database, mysql_user, mysql_pass, "com.mysql.jdbc.Driver")
+    curs = conn.cursor()
+    curs.execute("SELECT EXISTS(SELECT * FROM secret WHERE 'uuid' = ?)", (uuid,))
+    results = curs.fetchall()
+    curs.close()
+    conn.close()
+    return results[0][0] == 1
+
+def delete_pass(uuid):
+    conn = zxJDBC.connect(mysql_database, mysql_user, mysql_pass, "com.mysql.jdbc.Driver")
+    curs = conn.cursor()
+    curs.execute("DELETE FROM secret WHERE 'uuid' = ?", (uuid,))
+    curs.close()
+    conn.close()
+
+@hook.event("player.PlayerJoinEvent", "high")
 def on_join(event):
+    try:
+        thingy(event)
+    except:
+        print trace()
+
+
+def thingy(event):
     user = event.getPlayer()
-    if get_id(user) in passwords:
+    if is_registered(uid(user)):
-        withholdings[user.getName()] = now()
+        logging_in[user.getName()] = time.time()
 
 
-@hook.event("player.PlayerQuitEvent", "normal")
+@hook.event("player.PlayerQuitEvent", "high")
 def on_quit(event):
-    del withholdings[event.getPlayer().getName()]
+    del logging_in[event.getPlayer().getName()]
-
 
+##Threading start
 def kick_thread():
     wait_time_millis = wait_time * 1000
     while True:
-        if not run_kick_thread:
-            info("Exiting LoginSecurity kicking thread!")
-            thread.exit()
         time.sleep(1)
-        moment = now()
+        moment = time.time()
-        for name, jointime in withholdings.iteritems():
+        for name, jointime in logging_in.iteritems():
             if moment - jointime > wait_time_millis:
                 server.getPlayer(name).kickPlayer(colorify("&cLogin timed out"))
 
 
-thread.start_new_thread(kick_thread, ())
+thread = threading.Thread(target = kick_thread)
+thread.daemon = True
+thread.start()
+##Threading end
+
 
 for blocked_event in blocked_events:
-    @hook.event(blocked_event, "low")
+    @hook.event(blocked_event, "high")
     def on_blocked_event(event):
         user = event.getPlayer()
-        if user.getName() in withholdings:
+        if user.getName() in logging_in:
             event.setCancelled(True)
             msg(user, "&cYou have to log in first! Use /login <password>")

main.py

@@ -75,9 +75,9 @@ shared["load_modules"] = [
     #adds snowbrawl minigame
     "snowbrawl",
     # Adds /tm [player] for a messages to be sent to this player via /msg
-    "pmtoggle"
+    "pmtoggle",
     # Replacement for LoginSecurity
-    #"loginsecurity"
+    "loginsecurity"
 ]
 shared["modules"] = {}
 for module in shared["load_modules"]: