From 712cd135fc5695c5f40261246f730b0a755cb326 Mon Sep 17 00:00:00 2001 From: jomo Date: Sun, 27 Jul 2014 22:44:12 +0200 Subject: [PATCH] better name + docs for played_before (renamed to known_player) --- friends.py | 4 ++-- helpers.py | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/friends.py b/friends.py index 410eae8..4f24d79 100644 --- a/friends.py +++ b/friends.py @@ -59,7 +59,7 @@ def add(sender, names): for name in names: player = server.getOfflinePlayer(name) - if played_before(player): + if known_player(player): player_id = uid(player) not_yourself = player != sender @@ -93,7 +93,7 @@ def rem(sender, names): for name in names: player = server.getOfflinePlayer(name) - if played_before(player): + if known_player(player): player_id = uid(player) if player_id in friends.get(sender_id, []): friends[sender_id].remove(player_id) diff --git a/helpers.py b/helpers.py index 263c633..2c8426c 100644 --- a/helpers.py +++ b/helpers.py @@ -158,10 +158,11 @@ def retrieve_player(uuid_str): return server.getOfflinePlayer(juuid(uuid_str)) -def played_before(player): +def known_player(player): """ - returns True if the player has played before - this is different to getHasPlayed(), which will return False on first join + to be used on OfflinePlayer + returns True if the player has been on the server + this is different to HasPlayedBefore(), which will return False on first join """ return player.getFirstPlayed() != 0