Redstoner/redstoner.com
Archived
0
Fork 0
Code Issues Pull Requests 2 Wiki Activity

order by id instead of created_at

Browse Source 
id is indexed while created_at is not
This commit is contained in:
jomo
2017-07-07 01:57:30 +02:00
parent 4e1b6b430b
commit 72a6dcc54a
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/blogposts_controller.rb
View File

@@ -4,7 +4,7 @@ class BlogpostsController < ApplicationController
before_filter :auth, except: [:index, :show] before_filter :auth, except: [:index, :show]
def index def index
@posts = Blogpost.order("created_at desc").page(params[:page]).per(10) @posts = Blogpost.order(id: :desc).page(params[:page]).per(10)
end end
def show def show

4
app/controllers/forumthreads_controller.rb
View File

@@ -12,9 +12,9 @@ class ForumthreadsController < ApplicationController
end end
def show def show
if params[:reverse] == "true" if params[:reverse] == "true"
@replies = @thread.replies.order(created_at: :desc).page(params[:page]) @replies = @thread.replies.order(id: :desc).page(params[:page])
else else
@replies = @thread.replies.order(:created_at).page(params[:page]) @replies = @thread.replies.order(:id).page(params[:page])
end end
end end

2
app/models/forumthread.rb
View File

@@ -106,7 +106,7 @@ class Forumthread < ActiveRecord::Base
if order_phrase.present? if order_phrase.present?
threads = threads.order("GREATEST(relevance, reply_rel) DESC") threads = threads.order("GREATEST(relevance, reply_rel) DESC")
else else
threads = threads.order("sticky desc", "threadreplies.created_at DESC", "forumthreads.created_at DESC") threads = threads.order("sticky DESC", "threadreplies.id DESC", "forumthreads.id DESC")
end end
threads threads
end end

2
app/views/forums/index.html.erb
View File

@@ -18,7 +18,7 @@
<%= link_to f.name, f, id: "forum-#{f.id}"%> <%= link_to f.name, f, id: "forum-#{f.id}"%>
<div class="item-info"> <div class="item-info">
<% if last_thread = f.threads.last %> <% if last_thread = f.threads.last %>
<% last_reply = Threadreply.where(forumthread: f.threads).order(:created_at).last %> <% last_reply = Threadreply.where(forumthread: f.threads).order(:id).last %>
<% if last_reply && last_reply.created_at > last_thread.created_at %> <% if last_reply && last_reply.created_at > last_thread.created_at %>
<% if last_reply.thread.can_read?(current_user) %> <% if last_reply.thread.can_read?(current_user) %>
<%= last_reply.author.name %> <%= last_reply.author.name %>