Redstoner/redstoner.com
Archived
0
Fork 0
Code Issues Pull Requests 2 Wiki Activity

Optimized @players collection from json

Browse Source
This commit was merged in pull request #45.
This commit is contained in:
MrYummy
2017-10-29 22:26:16 +01:00
parent ea4799fc28
commit 7d766c8cf2
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/controllers/statics_controller.rb
View File

@@ -17,20 +17,15 @@ class StaticsController < ApplicationController
end end
def online def online
@players = {} @players = []
@count = 0 @count = 0
begin begin
json = JSON.parse(File.read("/etc/minecraft/redstoner/plugins/ModuleLoader/players.json")) json = JSON.parse(File.read("/etc/minecraft/redstoner/plugins/ModuleLoader/players.json"))["players"].reject{|p| !mod? && p["vanished"] == "true"}
rescue rescue
flash.now[:alert] = "The server is currently offline." flash.now[:alert] = "The server is currently offline."
else else
json["players"].each do |p| json.each do |p|
next if p["vanished"] == "true" && !mod? @players.push(User.find_by(uuid: p["UUID"].tr("-", "")) || User.new(name: p["name"], ign: p["name"], uuid: p["UUID"].tr("-", ""), role: Role.get("normal"), badge: Badge.get("none"), confirmed: true))
if User.find_by(uuid: p["UUID"].tr("-", ""))
@players.push(User.find_by(uuid: p["UUID"].tr("-", "")))
else
@players.push(User.new(name: p["name"], ign: p["name"], uuid: p["UUID"].tr("-", ""), role: Role.get("normal"), badge: Badge.get("none"), confirmed: true))
end
end end
end end
@players.sort_by!(&:role).reverse! @players.sort_by!(&:role).reverse!