Fix: Accessing threads in deleted forum, will deny access

2014-06-26 22:27:30 +02:00
parent 0ea9bd2e33
commit b03adf66d8
1 changed files with 4 additions and 6 deletions
--- a/app/controllers/forumthreads_controller.rb
+++ b/app/controllers/forumthreads_controller.rb
@@ -72,12 +72,10 @@ class ForumthreadsController < ApplicationController
  private

  def check_permission
-    if params[:id]
-      @thread = Forumthread.find(params[:id])
-      unless @thread.can_read?(current_user)
-        flash[:alert] = "You are not allowed to view this thread"
-        redirect_to forums_path
-      end
+    @thread = Forumthread.find(params[:id])
+    unless @thread.can_read?(current_user)
+      flash[:alert] = "You are not allowed to view this thread"
+      redirect_to forums_path
    end
  end