Added ban reason #41

2017-08-06T07:34:39-04:00

bruncbrunc commented

2017-08-06 07:34:39 -04:00

(Migrated from github.com)

No description provided.

jomo (Migrated from github.com) requested changes 2017-08-06 13:08:17 -04:00

jomo (Migrated from github.com) left a comment

Good idea!

app/controllers/users_controller.rb

						
				@@ -14,0 +26,4 @@

				    else

				      @users = User.joins(:role).where.not(id: User.first.id) #Remove first user

				    end

				    @users = @users.order("roles.value desc", "confirmed desc", :name)

jomo (Migrated from github.com) commented

2017-08-06 13:05:14 -04:00

This file can be quite huge, so it would be better to cache the parsed file (in the User model) for 10s or the likes

app/views/users/show.html.erb

jomo (Migrated from github.com) commented

2017-08-06 13:06:31 -04:00

This should say something along the lines of "banned on the server"

jomo (Migrated from github.com) commented

2017-08-06 13:07:14 -04:00

Server bans and website bans are two separate things, so just use two separate if blocks instead of if/elsif here.

jomo (Migrated from github.com) commented

2017-08-06 13:07:39 -04:00

Consequently, this should say "banned on the website".

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Redstoner/redstoner.com#41