Redstoner/ModuleLoader
Archived
0
Fork 0
Code Pull Requests Activity

Refactored timeout #5

Closed
ludvigk wants to merge 1 commits from patch-1 into master
pull from: patch-1
merge into: Redstoner:master
Conversation 3 Commits 1 Files Changed 1 +3 -2
ludvigk commented 2017-02-14 15:33:43 -05:00 (Migrated from github.com)
Copy Link
No description provided.
Pepich commented 2017-02-14 15:44:48 -05:00 (Migrated from github.com)
Copy Link

The lol timeout was made like that on purpose. The initial version had it by mistake, it came back as an easteregg. If you looked at the commit where I added the timeout, you would've realised that it is like that on purpose ;)

The lol timeout was made like that on purpose. The initial version had it by mistake, it came back as an easteregg. If you looked at the commit where I added the timeout, you would've realised that it is like that on purpose ;)
ludvigk commented 2017-02-14 19:28:07 -05:00 (Migrated from github.com)
Copy Link

Still, the use of Math.ceil, division, typecasting and "magic numbers" isn't exactly good standards in this case, is it?

Still, the use of Math.ceil, division, typecasting and "magic numbers" isn't exactly good standards in this case, is it?
Pepich commented 2017-02-15 13:49:03 -05:00 (Migrated from github.com)
Copy Link

If you actually meant this as an honest PR, then why did you:

Only change one of the spots?
Not update the version number?

Fix those issues, and make it count down from 14-0 with just the integer being displayed, then I'll reopen this PR :)

If you actually meant this as an honest PR, then why did you: Only change one of the spots? Not update the version number? Fix those issues, and make it count down from 14-0 with just the integer being displayed, then I'll reopen this PR :)
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
LogalDeveloper
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Redstoner/ModuleLoader#5
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?