Refactored timeout #5

2017-02-14T15:33:43-05:00

ludvigk commented

2017-02-14 15:33:43 -05:00

(Migrated from github.com)

No description provided.

Pepich commented

2017-02-14 15:44:48 -05:00

(Migrated from github.com)

The lol timeout was made like that on purpose. The initial version had it by mistake, it came back as an easteregg. If you looked at the commit where I added the timeout, you would've realised that it is like that on purpose ;)

ludvigk commented

2017-02-14 19:28:07 -05:00

(Migrated from github.com)

Still, the use of Math.ceil, division, typecasting and "magic numbers" isn't exactly good standards in this case, is it?

Pepich commented

2017-02-15 13:49:03 -05:00

(Migrated from github.com)

If you actually meant this as an honest PR, then why did you:

Only change one of the spots?
Not update the version number?

Fix those issues, and make it count down from 14-0 with just the integer being displayed, then I'll reopen this PR :)

If you actually meant this as an honest PR, then why did you: Only change one of the spots? Not update the version number? Fix those issues, and make it count down from 14-0 with just the integer being displayed, then I'll reopen this PR :)

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Redstoner/ModuleLoader#5