Refactored timeout #5
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Redstoner/ModuleLoader#5
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "patch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The lol timeout was made like that on purpose. The initial version had it by mistake, it came back as an easteregg. If you looked at the commit where I added the timeout, you would've realised that it is like that on purpose ;)
Still, the use of Math.ceil, division, typecasting and "magic numbers" isn't exactly good standards in this case, is it?
If you actually meant this as an honest PR, then why did you:
Only change one of the spots?
Not update the version number?
Fix those issues, and make it count down from 14-0 with just the integer being displayed, then I'll reopen this PR :)